Add types to constructors and private/final/internal methods (Batch I) #33519
Conversation
|
Do we really want to add types to |
|
I agree with @nicolas-grekas here. |
I find them helpful for understanding the tests.
I understand. Suggestion: I‘m going to remove changes I‘ve made to test case classes that also exist on the 3.4 branch. We can hold them back until 3.4 is EOL. |
that'd work for me (but if it's too tedious, you can surrender :) |
|
Status: needs work |
59a58b1 to
6d92236
Compare
|
Changes to tests have been moved into a separate branch: https://github.com/derrabus/symfony/tree/improvement/typed-tests I've kept the changes to the Error* components though because those components are new and thus shouldn't cause merge conflicts. |
|
Status: Needs Review |
6d92236 to
4039b95
Compare
|
Thank you @derrabus. |
…hods (Batch II) (derrabus) This PR was squashed before being merged into the 4.4 branch (closes #33709). Discussion ---------- Add types to constructors and private/final/internal methods (Batch II) | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | #32179, #33228 | License | MIT | Doc PR | N/A Followup to #33519, this time with: * Form * HttpClient * HttpKernel * intl * Ldap * Ldap * Lock * Messenger * Processor * PropertyInfo * Routing * Security * Serializer * Stopwatch * Translation Commits ------- 9378eb4 Add types to constructors and private/final/internal methods (Batch II)
…nal methods (Batch II) (derrabus) This PR was squashed before being merged into the 4.4 branch (closes symfony#33709). Discussion ---------- Add types to constructors and private/final/internal methods (Batch II) | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | symfony#32179, symfony#33228 | License | MIT | Doc PR | N/A Followup to symfony#33519, this time with: * Form * HttpClient * HttpKernel * intl * Ldap * Ldap * Lock * Messenger * Processor * PropertyInfo * Routing * Security * Serializer * Stopwatch * Translation Commits ------- 9378eb4 Add types to constructors and private/final/internal methods (Batch II)
…nal methods (Batch I) (derrabus) This PR was squashed before being merged into the 4.4 branch (closes symfony#33519). Discussion ---------- Add types to constructors and private/final/internal methods (Batch I) | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#32179, symfony#33228 | License | MIT | Doc PR | N/A As promised, now a larger batch with the following components: * Asset * BrowserKit * Config * Console * ~~CssSelector~~ * Debug * ~~DomCrawler~~ * DotEnv * ErrorHandler * ErrorRenderer * ExpressionLanguage * ~~Filesystem~~ * ~~Finder~~ Commits ------- 4039b95 Add types to constructors and private/final/internal methods (Batch I)
As promised, now a larger batch with the following components:
CssSelectorDomCrawlerFilesystemFinder