8000 [ErrorRenderer] Add types to constructors and private/final/internal … · symfony/symfony@6d92236 · GitHub
[go: up one dir, main page]

Skip to content

Commit 6d92236

Browse files
committed
[ErrorRenderer] Add types to constructors and private/final/internal methods.
1 parent 4f62641 commit 6d92236

File tree

6 files changed

+8
-8
lines changed

6 files changed

+8
-8
lines changed

src/Symfony/Component/ErrorRenderer/Exception/FlattenException.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,7 @@ public function setTrace($trace, $file, $line)
302302
return $this;
303303
}
304304

305-
private function flattenArgs(array $args, int $level = 0, int &$count = 0)
305+
private function flattenArgs(array $args, int $level = 0, int &$count = 0): array
306306
{
307307
$result = [];
308308
foreach ($args as $key => $value) {
@@ -338,7 +338,7 @@ private function flattenArgs(array $args, int $level = 0, int &$count = 0)
338338
return $result;
339339
}
340340

341-
private function getClassNameFromIncomplete(\__PHP_Incomplete_Class $value)
341+
private function getClassNameFromIncomplete(\__PHP_Incomplete_Class $value): string
342342
{
343343
$array = new \ArrayObject($value);
344344

src/Symfony/Component/ErrorRenderer/Tests/ErrorRenderer/HtmlErrorRendererTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public function testRender(FlattenException $exception, ErrorRendererInterface $
2626
$this->assertStringMatchesFormat($expected, $errorRenderer->render($exception));
2727
}
2828

29-
public function getRenderData()
29+
public function getRenderData(): iterable
3030
{
3131
$expectedDebug = <<<HTML
3232
<!-- Foo (500 Internal Server Error) -->

src/Symfony/Component/ErrorRenderer/Tests/ErrorRenderer/JsonErrorRendererTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public function testRender(FlattenException $exception, ErrorRendererInterface $
2626
$this->assertStringMatchesFormat($expected, $errorRenderer->render($exception));
2727
}
2828

29-
public function getRenderData()
29+
public function getRenderData(): iterable
3030
{
3131
$expectedDebug = <<<JSON
3232
{

src/Symfony/Component/ErrorRenderer/Tests/ErrorRenderer/TxtErrorRendererTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public function testRender(FlattenException $exception, ErrorRendererInterface $
2626
$this->assertStringMatchesFormat($expected, $errorRenderer->render($exception));
2727
}
2828

29-
public function getRenderData()
29+
public function getRenderData(): iterable
3030
{
3131
$expectedDebug = <<<TXT
3232
[title] Internal Server Error

src/Symfony/Component/ErrorRenderer/Tests/ErrorRenderer/XmlErrorRendererTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public function testRender(FlattenException $exception, ErrorRendererInterface $
2626
$this->assertStringMatchesFormat($expected, $errorRenderer->render($exception));
2727
}
2828

29-
public function getRenderData()
29+
public function getRenderData(): iterable
3030
{
3131
$expectedDebug = <<<XML
3232
<?xml version="1.0" encoding="UTF-8" ?>

src/Symfony/Component/ErrorRenderer/Tests/Exception/FlattenExceptionTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ public function testCreate()
227227
);
228228
}
229229

230-
public function flattenDataProvider()
230+
public function flattenDataProvider(): array
231231
{
232232
return [
233233
[new \Exception('test', 123), 'Exception'],
@@ -381,7 +381,7 @@ public function testToStringParent()
381381
$this->assertSame($exception->__toString(), $flattened->getAsString());
382382
}
383383

384-
private function createException($foo)
384+
private function createException($foo): \Exception
385385
{
386386
return new \Exception();
387387
}

0 commit comments

Comments
 (0)
0