8000 fix tests mocking final events by Tobion · Pull Request #33482 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

fix tests mocking final events #33482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2019
Merged

fix tests mocking final events #33482

merged 1 commit into from
Sep 6, 2019

Conversation

Tobion
Copy link
Contributor
@Tobion Tobion commented Sep 5, 2019 •
edited
Loading
Q A
Branch? 4.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #...
License MIT
Doc PR

Fix tests in 4.4 extracted from #33297

@Tobion Tobion mentioned this pull request Sep 5, 2019
Merged
@nicolas-grekas nicolas-grekas added this to the next milestone Sep 5, 2019
@nicolas-grekas
Copy link
Member

Thank you @Tobion.

nicolas-grekas added a commit that referenced this pull request Sep 6, 2019
@nicolas-grekas
minor #33482 fix tests mocking final events (Tobion)
9d472c7 
This PR was merged into the 4.4 branch.

Discussion
----------

fix tests mocking final events

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        |

Fix tests in 4.4 extracted from #33297

Commits
-------

637461f fix tests mocking final events
@nicolas-grekas nicolas-grekas merged commit 637461f into symfony:4.4 Sep 6, 2019
@Tobion Tobion deleted the fix-tests-mocking-events branch September 6, 2019 15:58
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@Tobion @nicolas-grekas @derrabus @carsonbot
0