Make dispatched events really final #33297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6d000f2 to
9b22176
Compare
ro0NL
reviewed
Aug 23, 2019
|
Extracted updating tests for 4.4 in #33482 |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 6, 2019
This PR was merged into the 4.4 branch. Discussion ---------- fix tests mocking final events | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | Fix tests in 4.4 extracted from #33297 Commits ------- 637461f fix tests mocking final events
|
rebase unlocked. |
9b22176 to
b87d41d
Compare
|
Rebased and tests pass |
nicolas-grekas
approved these changes
Sep 6, 2019
src/Symfony/Component/Security/Http/Event/InteractiveLoginEvent.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Http/Event/InteractiveLoginEvent.php
Outdated
Show resolved
Hide resolved
derrabus
approved these changes
Sep 6, 2019
b87d41d to
11c83a2
Compare
11c83a2 to
953057f
Compare
fabpot
approved these changes
Sep 8, 2019
|
Thank you @Tobion. |
fabpot
added a commit
that referenced
this pull request
Sep 8, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- Make dispatched events really final | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | | License | MIT | Doc PR | Continuation of #33152 for master Commits ------- 953057f Make dispatched events really final
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #33152 for master