8000 [SecurityBundle] Fix 4.3 tests forward compat by yceruto · Pull Request #33479 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[SecurityBundle] Fix 4.3 tests forward compat #33479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2019
Merged

[SecurityBundle] Fix 4.3 tests forward compat #33479

merged 1 commit into from
Sep 6, 2019

Conversation

yceruto
Copy link
Member
@yceruto yceruto commented Sep 5, 2019 •
edited
Loading
Q A
Branch? 4.3
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #33478
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Sep 5, 2019
@derrabus derrabus mentioned this pull request Sep 5, 2019
Closed
@nicolas-grekas
Copy link
Member

What about the BC break part @derrabus mentions in the linked issue? I didn't try to understand it, what about you? :)

@yceruto
Copy link
Member Author
yceruto commented Sep 5, 2019 •
edited
Loading

What about the BC break part @derrabus mentions in the linked issue? I didn't try to understand it, what about you? :)

It's not a BC break to me, but a side effect of the previous behavior related to PHPUnit and the exception handler. See #33478 (comment)

@yceruto yceruto force-pushed the fix_43_tests branch 2 times, most recently from 2a7413b to f092331 Compare September 5, 2019 18:03
Tobion
Tobion reviewed Sep 5, 2019
View reviewed changes
src/Symfony/Bundle/SecurityBundle/Tests/Functional/app/MissingUserProvider/config.yml
@@ -1,5 +1,5 @@
imports:
- { resource: ./../config/framework.yml }
- { resource: ./../config/default.yml }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should that be reverted in 4.4 again?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yap!

@nicolas-grekas
Copy link
Member

Thank you @yceruto.

nicolas-grekas added a commit that referenced this pull request Sep 6, 2019
@nicolas-grekas
minor #33479 [SecurityBundle] Fix 4.3 tests forward compat (yceruto)
2feae7b 
This PR was merged into the 4.3 branch.

Discussion
----------

[SecurityBundle] Fix 4.3 tests forward compat

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #33478
| License       | MIT
| Doc PR        | -

Commits
-------

f092331 Fix 4.3 tests forward compat
@nicolas-grekas nicolas-grekas merged commit f092331 into symfony:4.3 Sep 6, 2019
@yceruto yceruto mentioned this pull request Sep 6, 2019
Merged
nicolas-grekas added a commit that referenced this pull request Sep 6, 2019
@nicolas-grekas
minor #33495 [SecurityBundle] Removed workaround introduced in 4.3 (y…
a2d2911 
…ceruto)

This PR was merged into the 4.4 branch.

Discussion
----------

[SecurityBundle] Removed workaround introduced in 4.3

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Cleanup of #33479

Commits
-------

d14aaf6 Removed workaround introduced in 4.3
@yceruto yceruto deleted the fix_43_tests branch October 23, 2019 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@Tobion Tobion Tobion approved these changes

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
SecurityBundle Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
5 participants
@yceruto @nicolas-grekas @Tobion @derrabus @carsonbot
0