minor #33479 [SecurityBundle] Fix 4.3 tests forward compat (yceruto)

nicolas-grekas · nicolas-grekas · commit 2feae7bebbeb · 2019-09-06T11:49:53.000+02:00
This PR was merged into the 4.3 branch. Discussion ---------- [SecurityBundle] Fix 4.3 tests forward compat | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #33478 | License | MIT | Doc PR | - Commits ------- f092331 Fix 4.3 tests forward compat
diff --git a/src/Symfony/Bundle/SecurityBundle/Tests/Functional/MissingUserProviderTest.php b/src/Symfony/Bundle/SecurityBundle/Tests/Functional/MissingUserProviderTest.php
@@ -15,13 +15,16 @@ class MissingUserProviderTest extends AbstractWebTestCase
 {
     public function testUserProviderIsNeeded()
     {
-        $this->expectException('Symfony\Component\Config\Definition\Exception\InvalidConfigurationException');
-        $this->expectExceptionMessage('"default" firewall requires a user provider but none was defined.');
-        $client = $this->createClient(['test_case' => 'MissingUserProvider', 'root_config' => 'config.yml']);
+        $client = $this->createClient(['test_case' => 'MissingUserProvider', 'root_config' => 'config.yml', 'debug' => true]);
 
         $client->request('GET', '/', [], [], [
             'PHP_AUTH_USER' => 'username',
             'PHP_AUTH_PW' => 'pa$$word',
         ]);
+
+        $response = $client->getResponse();
+        $this->assertSame(500, $response->getStatusCode());
+        $this->stringContains('Symfony\Component\Config\Definition\Exception\InvalidConfigurationException', $response->getContent());
+        $this->stringContains('"default" firewall requires a user provider but none was defined.', $response->getContent());
     }
 }
diff --git a/src/Symfony/Bundle/SecurityBundle/Tests/Functional/app/MissingUserProvider/bundles.php b/src/Symfony/Bundle/SecurityBundle/Tests/Functional/app/MissingUserProvider/bundles.php
@@ -16,5 +16,6 @@
 return [
     new FrameworkBundle(),
     new SecurityBundle(),
+    new Symfony\Bundle\TwigBundle\TwigBundle(),
     new MissingUserProviderBundle(),
 ];
diff --git a/src/Symfony/Bundle/SecurityBundle/Tests/Functional/app/MissingUserProvider/config.yml b/src/Symfony/Bundle/SecurityBundle/Tests/Functional/app/MissingUserProvider/config.yml
@@ -1,5 +1,5 @@
 imports:
-    - { resource: ./../config/framework.yml }
+    - { resource: ./../config/default.yml }
 
 security:
     firewalls:

Original file line number	Diff line number	Diff line change
`@@ -15,13 +15,16 @@ class MissingUserProviderTest extends AbstractWebTestCase`
`15`	`15`	`{`
`16`	`16`	`public function testUserProviderIsNeeded()`
`17`	`17`	`{`
`18`		`- $this->expectException('Symfony\Component\Config\Definition\Exception\InvalidConfigurationException');`
`19`		`- $this->expectExceptionMessage('"default" firewall requires a user provider but none was defined.');`
`20`		`- $client = $this->createClient(['test_case' => 'MissingUserProvider', 'root_config' => 'config.yml']);`
	`18`	`+ $client = $this->createClient(['test_case' => 'MissingUserProvider', 'root_config' => 'config.yml', 'debug' => true]);`
`21`	`19`
`22`	`20`	`$client->request('GET', '/', [], [], [`
`23`	`21`	`'PHP_AUTH_USER' => 'username',`
`24`	`22`	`'PHP_AUTH_PW' => 'pa$$word',`
`25`	`23`	`]);`
	`24`	`+`
	`25`	`+ $response = $client->getResponse();`
	`26`	`+ $this->assertSame(500, $response->getStatusCode());`
	`27`	`+ $this->stringContains('Symfony\Component\Config\Definition\Exception\InvalidConfigurationException', $response->getContent());`
	`28`	`+ $this->stringContains('"default" firewall requires a user provider but none was defined.', $response->getContent());`
`26`	`29`	`}`
`27`	`30`	`}`