8000 [EventDispatcher] Fix mocks for ImmutableEventDispatcher by derrabus · Pull Request #33299 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[EventDispatcher] Fix mocks for ImmutableEventDispatcher #33299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2019
Merged

[EventDispatcher] Fix mocks for ImmutableEventDispatcher #33299

merged 1 commit into from
Aug 23, 2019

Conversation

derrabus
Copy link
Member
Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #33228
License MIT
Doc PR N/A

Backport from #33248. This PR fixes mocks that return values that are incompatible with the annotated return type.

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Aug 23, 2019
@derrabus derrabus force-pushed the bugfix/immutable-ed-mock branch from 5d3d385 to 874aaea Compare August 23, 2019 08:06
@derrabus derrabus mentioned this pull request Aug 23, 2019
Merged
@nicolas-grekas
Copy link
Member

Thank you @derrabus.

nicolas-grekas added a commit that referenced this pull request Aug 23, 2019
@nicolas-grekas
minor #33299 [EventDispatcher] Fix mocks for ImmutableEventDispatcher…
1f72501 
… (derrabus)

This PR was merged into the 3.4 branch.

Discussion
----------

[EventDispatcher] Fix mocks for ImmutableEventDispatcher

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #33228
| License       | MIT
| Doc PR        | N/A

Backport from #33248. This PR fixes mocks that return values that are incompatible with the annotated return type.

Commits
-------

874aaea Fix mocks for ImmutableEventDispatcher.
@nicolas-grekas nicolas-grekas merged commit 874aaea into symfony:3.4 Aug 23, 2019
@derrabus derrabus deleted the bugfix/immutable-ed-mock branch August 23, 2019 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug EventDispatcher Status: Needs Review
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@derrabus @nicolas-grekas @carsonbot
0