[EventDispatcher] Add return type declarations #33248
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 tasks
nicolas-grekas
added a commit
that referenced
this pull request
Aug 23, 2019
… (derrabus) This PR was merged into the 3.4 branch. Discussion ---------- [EventDispatcher] Fix mocks for ImmutableEventDispatcher | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #33228 | License | MIT | Doc PR | N/A Backport from #33248. This PR fixes mocks that return values that are incompatible with the annotated return type. Commits ------- 874aaea Fix mocks for ImmutableEventDispatcher.
21a4538 to
7eb9d14
Compare
|
@derrabus what the status here? We'd like to tag beta yesterday :) |
|
Confirmed closable on slack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge (see #33236). This PR illustrates how a fully typed event dispatcher component would look like, including everything that might break on the way and the impact the change has on other components.
The impact for userland implementation would be heavy, mainly because the changed
EventSubscriberInterfaceis quite popular. If we would revert that interface, I would expect a pretty low impact: after all, applications/libraries rarely need to implement their own event dispatcher.Fixes to tests and inconsistent return points will be backported.