8000 Unescape paramaters by stof · Pull Request #3260 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Unescape paramaters #3260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 4, 2012
Merged

Unescape paramaters #3260

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a1b6d4c
Added a failing testcase for escaped % in array parameters
lsmith77 Feb 2, 2012
045f936
Changed the testcase to expect the unescaping only after the resolution
stof Feb 2, 2012
8e13095
Fixed the unescaping of parameters to handle arrays
stof Feb 2, 2012
a7b48c0
Renamed the method
stof Feb 2, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Added a failing testcase for escaped % in array parameters
  • Loading branch information
@lsmith77 @stof
lsmith77 authored and stof committed Feb 2, 2012
commit a1b6d4c46b43d8a798eeec5807670bf675917cb8
1 change: 1 addition & 0 deletions tests/Symfony/Tests/Component/DependencyInjection/ParameterBag/ParameterBagTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ public function testResolveValue()
$this->assertEquals(array('bar' => array('bar' => array('bar' => 'bar'))), $bag->resolveValue(array('%foo%' => array('%foo%' => array('%foo%' => '%foo%')))), '->resolveValue() replaces placeholders in nested arrays');
$this->assertEquals('I\'m a %%foo%%', $bag->resolveValue('I\'m a %%foo%%'), '->resolveValue() supports % escaping by doubling it');
$this->assertEquals('I\'m a bar %%foo bar', $bag->resolveValue('I\'m a %foo% %%foo %foo%'), '->resolveValue() supports % escaping by doubling it');
$this->assertEquals(array('foo' => array('bar' => array('ding' => 'I\'m a bar %foo %bar'))), $bag->resolveValue(array('foo' => array('bar' => array('ding' => 'I\'m a bar %%foo %%bar')))), '->resolveValue() supports % escaping by doubling it');

$bag = new ParameterBag(array('foo' => true));
$this->assertSame(true, $bag->resolveValue('%foo%'), '->resolveValue() replaces arguments that are just a placeholder by their value without casting them to strings');
Expand Down
0