Unescape paramaters #3260
Merged
Unescape paramaters #3260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
String values are not unescaped either in resolveValue() because it can be called several times for the same parameter.
| } | ||
|
|
||
| if (is_array($value)) { | ||
| $result = array(); |
There was a problem hiding this comment.
Do we need a local variable here ? (What a pleasure to comment @stof code !)
There was a problem hiding this comment.
not sure. I wrote it the way it is done in resolve() but resolve requires it because of the resolveValue call
There was a problem hiding this comment.
btw, this made me think about a possible issue with the unescaping. I will try to confirm it with a testcase so wait a bit before merging
There was a problem hiding this comment.
ok, the case I thought about does not break things. I tried too invent edge cases that don't exist.
fabpot
added a commit
that referenced
this pull request
Feb 4, 2012
Commits ------- a7b48c0 Renamed the method 8e13095 Fixed the unescaping of parameters to handle arrays 045f936 Changed the testcase to expect the unescaping only after the resolution a1b6d4c Added a failing testcase for escaped % in array parameters Discussion ---------- Unescape paramaters This fixes the unescaping of % in parameters when it is used in an array. It is a replacement for @lsmith77's work done in #3241 but with a working fix this time :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the unescaping of % in parameters when it is used in an array.
It is a replacement for @lsmith77's work done in #3241 but with a working fix this time :)