Read PHPUnit configuration to check for listeners too #31649
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $configuration = Configuration::getInstance($this->arguments['configuration']); | ||
| } | ||
| foreach ($configuration->getListenerConfiguration() as $registeredListener) { | ||
| if (is_subclass_of($registeredListener['class'], SymfonyTestsListenerForV5::class)) { |
There was a problem hiding this comment.
or Symfony\Bridge\PhpUnit\SymfonyTestsListener in both classes?
There was a problem hiding this comment.
Yeah that was a mistake. Interestingly whilst debugging this locally doing
is_subclass_of($registeredListener['class'], SymfonyTestsListener::class) was not working even though
$registeredListener['class'] was Symfony\Bridge\PhpUnit\SymfonyTestsListener ?!?!?
dce0147 to
4226b90
Compare
23e9dba to
80cd0c3
Compare
|
Should target 3.4 since it's a bug fix? |
|
@greg0ire maybe you'd have some time to take over this PR? It'd be great :) |
|
I'll give it a look :) |
|
@alexpott https://www.drupal.org/project/drupal/issues/303934 gives me a 404 |
greg0ire
pushed a commit
to greg0ire/symfony
that referenced
this pull request
Aug 3, 2019
The listener can be registered via configuration by the user. In that case, we do not want to add it again to the list of listeners. Closes symfony#31649
greg0ire
pushed a commit
to greg0ire/symfony
that referenced
this pull request
Aug 3, 2019
The listener can be registered via configuration by the user. In that case, we do not want to add it again to the list of listeners. Closes symfony#31649
greg0ire
pushed a commit
to greg0ire/symfony
that referenced
this pull request
Aug 3, 2019
The bridge listener can be registered via configuration by the user. In that case, we do not want to add it again to the list of listeners. Closes symfony#31649
greg0ire
pushed a commit
to greg0ire/symfony
that referenced
this pull request
Aug 8, 2019
The bridge listener can be registered via configuration by the user. In that case, we do not want to add it again to the list of listeners. Closes symfony#31649
|
closing in favor of #32903 |
greg0ire
pushed a commit
to greg0ire/symfony
that referenced
this pull request
Sep 2, 2019
The bridge listener can be registered via configuration by the user. In that case, we do not want to add it again to the list of listeners. Closes symfony#31649
nicolas-grekas
added a commit
that referenced
this pull request
Sep 2, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [PHPUnit Bridge] Avoid registering listener twice The listener can be registered via configuration by the user. In that case, we do not want to add it again to the list of listeners. Closes #31649 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- b190536 Check phpunit configuration for listeners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to use simple-phpunit to get around phpunit dependency fun and support many versions of PHP in Drupal. See https://www.drupal.org/project/drupal/issues/303934. We're running into an issue that we register the Symfony event listener in our phpunit.xml file. We need to do this because we wrap your listener and intercept some deprecations. Without this fix the symfony tests listener gets registered twice.