[PHPUnit Bridge] Avoid registering listener twice #32903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0921e34 to
5936735
Compare
Simperfit
approved these changes
Aug 5, 2019
xabbuh
requested changes
Aug 8, 2019
OskarStark
approved these changes
Aug 26, 2019
|
@xabbuh can we merge this one? |
|
/cc @nicolas-grekas |
nicolas-grekas
approved these changes
Sep 2, 2019
The bridge listener can be registered via configuration by the user. In that case, we do not want to add it again to the list of listeners. Closes symfony#31649
9850c3c to
b190536
Compare
addressed :) |
|
/cc @alexpott FYI |
|
Thank you @greg0ire. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 2, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [PHPUnit Bridge] Avoid registering listener twice The listener can be registered via configuration by the user. In that case, we do not want to add it again to the list of listeners. Closes #31649 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- b190536 Check phpunit configuration for listeners
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The listener can be registered via configuration by the user. In that
case, we do not want to add it again to the list of listeners.
Closes #31649