-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[PHPUnit Bridge] Avoid registering listener twice #32903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0921e34
to
5936735
Compare
@xabbuh can we merge this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/cc @nicolas-grekas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(just minor CS nitpicking)
The bridge listener can be registered via configuration by the user. In that case, we do not want to add it again to the list of listeners. Closes symfony#31649
9850c3c
to
b190536
Compare
addressed :) |
/cc @alexpott FYI |
Thank you @greg0ire. |
This PR was merged into the 3.4 branch. Discussion ---------- [PHPUnit Bridge] Avoid registering listener twice The listener can be registered via configuration by the user. In that case, we do not want to add it again to the list of listeners. Closes #31649 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- b190536 Check phpunit configuration for listeners
The listener can be registered via configuration by the user. In that
case, we do not want to add it again to the list of listeners.
Closes #31649