8000 [PHPUnit Bridge] Avoid registering listener twice by greg0ire · Pull Request #32903 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[PHPUnit Bridge] Avoid registering listener twice #32903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2019

Conversation

greg0ire
Copy link
Contributor
@greg0ire greg0ire commented Aug 3, 2019

The listener can be registered via configuration by the user. In that
case, we do not want to add it again to the list of listeners.
Closes #31649

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

@greg0ire greg0ire force-pushed the carry-31649 branch 2 times, most recently from 0921e34 to 5936735 Compare August 3, 2019 12:47
@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Aug 3, 2019
@OskarStark
Copy link
Contributor

@xabbuh can we merge this one?

Copy link
Member
@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fabpot
Copy link
Member
fabpot commented Aug 30, 2019

/cc @nicolas-grekas

Copy link
Member
@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(just minor CS nitpicking)

The bridge listener can be registered via configuration by the user. In that
case, we do not want to add it again to the list of listeners.
Closes symfony#31649
@greg0ire
Copy link
Contributor Author
greg0ire commented Sep 2, 2019

just minor CS nitpicking

addressed :)

@nicolas-grekas
Copy link
Member

/cc @alexpott FYI

@nicolas-grekas
Copy link
Member

Thank you @greg0ire.

nicolas-grekas added a commit that referenced this pull request Sep 2, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

[PHPUnit Bridge] Avoid registering listener twice

The listener can be registered via configuration by the user. In that
case, we do not want to add it again to the list of listeners.
Closes #31649

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

b190536 Check phpunit configuration for listeners
@nicolas-grekas nicolas-grekas merged commit b190536 into symfony:3.4 Sep 2, 2019
@greg0ire greg0ire deleted the carry-31649 branch September 2, 2019 20:07
@fabpot fabpot mentioned this pull request Oct 7, 2019
@fabpot fabpot mentioned this pull request Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants
0