8000 [HttpClient] Removed undefined variable by derrabus · Pull Request #30927 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpClient] Removed undefined variable #30927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2019
Merged

[HttpClient] Removed undefined variable #30927

merged 1 commit into from
Apr 6, 2019

Conversation

derrabus
Copy link
Member
@derrabus derrabus commented Apr 6, 2019 •
edited
Loading
Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

The variable $noProxy is accessed here before it is defined.

EU-FOSSA

8000
@chalasr chalasr added this to the next milestone Apr 6, 2019
nicolas-grekas
nicolas-grekas approved these changes Apr 6, 2019
View reviewed changes
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, a leftover from when this was a constructor argument

@fabpot
Copy link
Member
fabpot commented Apr 6, 2019

Thank you @derrabus.

1 similar comment
@nicolas-grekas
Copy link
Member

Thank you @derrabus.

@fabpot fabpot merged commit 69f0a0b into symfony:master Apr 6, 2019
fabpot added a commit that referenced this pull request Apr 6, 2019
@fabpot
minor #30927 [HttpClient] Removed undefined variable (derrabus)
58d78ac 
This PR was merged into the 4.3-dev branch.

Discussion
----------

[HttpClient] Removed undefined variable

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

The variable `$noProxy` is accessed here before it is defined.

`EU-FOSSA`

Commits
-------

69f0a0b Removed undefined variable.
@derrabus derrabus deleted the bugfix/undefined-noProxy branch April 6, 2019 19:50
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug HttpClient Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
6 participants
@derrabus @fabpot @nicolas-grekas @javiereguiluz @chalasr @carsonbot
0