8000 minor #30927 [HttpClient] Removed undefined variable (derrabus) · symfony/symfony@58d78ac · GitHub
[go: up one dir, main page]

Skip to content

Commit 58d78ac

Browse files
committed
minor #30927 [HttpClient] Removed undefined variable (derrabus)
This PR was merged into the 4.3-dev branch. Discussion ---------- [HttpClient] Removed undefined variable | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A The variable `$noProxy` is accessed here before it is defined. `EU-FOSSA` Commits ------- 69f0a0b Removed undefined variable.
2 parents ce220cd + 69f0a0b commit 58d78ac

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/Symfony/Component/HttpClient/NativeHttpClient.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ public function request(string $method, string $url, array $options = []): Respo
201201
];
202202

203203
$proxy = self::getProxy($options['proxy'], $url);
204-
$noProxy = $noProxy ?? $_SERVER['no_proxy'] ?? $_SERVER['NO_PROXY'] ?? '';
204+
$noProxy = $_SERVER['no_proxy'] ?? $_SERVER['NO_PROXY'] ?? '';
205205
$noProxy = $noProxy ? preg_split('/[\s,]+/', $noProxy) : [];
206206

207207
$resolveRedirect = self::createRedirectResolver($options, $host, $proxy, $noProxy, $info, $onProgress);

0 commit comments

Comments
 (0)
0