[Validator] Add the missing translations for the French (fr) locale #30199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DelanoueMartin yes, we're updating the English file in the 3.4 branch as well to add the missing translations (#30157) |
javiereguiluz
approved these changes
Feb 12, 2019
fabpot
approved these changes
Feb 12, 2019
|
Thank you @DelanoueMartin. |
fabpot
added a commit
that referenced
this pull request
Feb 12, 2019
…(fr) locale (Martin) This PR was merged into the 3.4 branch. Discussion ---------- [Validator] Add the missing translations for the French (fr) locale | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #30164 | License | MIT | Doc PR | - To simplify things, translated files contains all the keys of the French file in `master` branch. That's why our translations in 3.4 branch contain the keys `id = 84` and `id = 85` even if that is not used in 3.4 branch. I propose to also include that unused key in the French file to make it easier to keep things in sync. Commits ------- 9a86504 [Validator] Add the missing translations for the French (fr) locale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To simplify things, translated files contains all the keys of the English file in
masterbranch. That's why our translations in 3.4 branch contain the keysid = 84andid = 85even if that is not used in 3.4 branch.I propose to also include that unused key in the French file to make it easier to keep things in sync.