8000 [Validator] Add some missing contents to the English translation by javiereguiluz · Pull Request #30157 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Validator] Add some missing contents to the English translation #30157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

javiereguiluz
Copy link
Member
Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

To simplify things, translated files contains all the keys of the English file in master branch. That's why our translations in 3.4 branch contain the key id = 85 even if that is not used in 3.4 branch.

I propose to also include that unused key in the English file to make it easier to keep things in sync.

@sstok
Copy link
Contributor
sstok commented Feb 12, 2019

FYI. The id can be anything as long as it's unique for the file, even a uuid can used.

@fabpot
Copy link
Member
fabpot commented Feb 12, 2019

Thank you @javiereguiluz.

9EAF
@fabpot fabpot merged commit ce4ff50 into 3.4 Feb 12, 2019
fabpot added a commit that referenced this pull request Feb 12, 2019
…nslation (javiereguiluz)

This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] Add some missing contents to the English translation

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

To simplify things, translated files contains all the keys of the English file in `master` branch. That's why our translations in 3.4 branch contain the key `id = 85` even if that is not used in 3.4 branch.

I propose to also include that unused key in the English file to make it easier to keep things in sync.

Commits
-------

ce4ff50 [Validator] Add some missing contents to the English translation
@nicolas-grekas nicolas-grekas deleted the validator-en branch February 13, 2019 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0