Fix wrong value in file id attribute for Xliff 2.0 #30074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f32f037 to
02614ef
Compare
OskarStark
reviewed
Feb 5, 2019
8043038 to
8ed345e
Compare
|
Tests added, and tests are green ;) |
8ed345e to
6006b43
Compare
nicolas-grekas
approved these changes
Feb 5, 2019
|
Thank you very much |
OskarStark
approved these changes
Feb 5, 2019
xabbuh
approved these changes
Feb 5, 2019
6006b43 to
8bf12f8
Compare
|
Thank you @deguif. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 7, 2019
This PR was squashed before being merged into the 4.2 branch (closes #30074). Discussion ---------- Fix wrong value in file id attribute for Xliff 2.0 | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | ? | Deprecations? | no | Tests pass? | ? | Fixed tickets | | License | MIT | Doc PR | Currently using the `XliffFileDumper` for exporting messages from catalogue with domain of the form `xxxx+intl-icu` produces an invalid Xliff version 2.0 file as the file id attribute is of type `xs:NMTOKEN` (cf. https://github.com/symfony/translation/blob/master/Resources/schemas/xliff-core-2.0.xsd#L139) which doesn't accept `+` character (cf. http://www.datypic.com/sc/xsd/t-xsd_NMTOKEN.html). Exception is thrown when loading the content after. Commits ------- 8bf12f8 Fix wrong value in file id attribute for Xliff 2.0
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently using the
XliffFileDumperfor exporting messages from catalogue with domain of the formxxxx+intl-icuproduces an invalid Xliff version 2.0 file as the file id attribute is of typexs:NMTOKEN(cf. https://github.com/symfony/translation/blob/master/Resources/schemas/xliff-core-2.0.xsd#L139) which doesn't accept+character (cf. http://www.datypic.com/sc/xsd/t-xsd_NMTOKEN.html).Exception is thrown when loading the content after.