8000 Fix non allowed + character in xliff file id attribute · symfony/symfony@f32f037 · GitHub
[go: up one dir, main page]

Skip to content

Commit f32f037

Browse files
committed
Fix non allowed + character in xliff file id attribute
1 parent d4f4d8a commit f32f037

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

src/Symfony/Component/Translation/Dumper/XliffFileDumper.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,11 @@ private function dumpXliff2($defaultLocale, MessageCatalogue $messages, $domain,
141141
$xliff->setAttribute('trgLang', str_replace('_', '-', $messages->getLocale()));
142142

143143
$xliffFile = $xliff->appendChild($dom->createElement('file'));
144-
$xliffFile->setAttribute('id', $domain.'.'.$messages->getLocale());
144+
if (MessageCatalogue::INTL_DOMAIN_SUFFIX === substr($domain, -($domainLength = strlen(MessageCatalogue::INTL_DOMAIN_SUFFIX)))) {
145+
$xliffFile->setAttribute('id', substr($domain, 0, -$domainLength).'.'.$messages->getLocale());
146+
} else {
147+
$xliffFile->setAttribute('id', $domain.'.'.$messages->getLocale());
148+
}
145149

146150
foreach ($messages->all($domain) as $source => $target) {
147151
$translation = $dom->createElement('unit');

0 commit comments

Comments
 (0)
0