Mark some/most implementations of Serializable as @internal
#30035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Jan 30, 2019
nicolas-grekas
added a commit
that referenced
this pull request
Jan 30, 2019
…rnal` (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- Mark some/most implementations of Serializable as `@internal` | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - There are more usages of `Serializable` in the code base, but the remaining are unfortunately exposed as part of interfaces. All these places are IMHO already considered internal, this just makes it explicit. Will ease moving away from `Serializable`. Commits ------- 7b9d73d Mark some/most implementations of Serializable as `@internal`
nicolas-grekas
added a commit
that referenced
this pull request
Feb 8, 2019
…ation methods (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- Remove "internal" annotation from datacollector serialization methods | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I've been a bit too aggressively adding `@internal` in #30035. Commits ------- 3c8fd20 Remove "internal" annotation from datacollector serialization methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are more usages of
Serializablein the code base, but the remaining are unfortunately exposed as part of interfaces.All these places are IMHO already considered internal, this just makes it explicit.
Will ease moving away from
Serializable.