minor #30112 Remove "internal" annotation from datacollector serialization methods (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit bb54e40ca703 · 2019-02-08T13:55:24.000+01:00
This PR was merged into the 3.4 branch. Discussion ---------- Remove "internal" annotation from datacollector serialization methods | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I've been a bit too aggressively adding `@internal` in #30035. Commits ------- 3c8fd20 Remove "internal" annotation from datacollector serialization methods
diff --git a/src/Symfony/Component/Form/Extension/DataCollector/FormDataCollector.php b/src/Symfony/Component/Form/Extension/DataCollector/FormDataCollector.php
@@ -228,9 +228,6 @@ public function getData()
         return $this->data;
     }
 
-    /**
-     * @internal
-     */
     public function serialize()
     {
         if ($this->hasVarDumper) {
diff --git a/src/Symfony/Component/HttpKernel/DataCollector/DataCollector.php b/src/Symfony/Component/HttpKernel/DataCollector/DataCollector.php
@@ -40,9 +40,6 @@ abstract class DataCollector implements DataCollectorInterface, \Serializable
      */
     private $cloner;
 
-    /**
-     * @internal
-     */
     public function serialize()
     {
         $trace = debug_backtrace(DEBUG_BACKTRACE_PROVIDE_OBJECT, 2);
@@ -51,9 +48,6 @@ public function serialize()
         return $isCalledFromOverridingMethod ? $this->data : serialize($this->data);
     }
 
-    /**
-     * @internal
-     */
     public function unserialize($data)
     {
         $this->data = \is_array($data) ? $data : unserialize($data);
diff --git a/src/Symfony/Component/HttpKernel/DataCollector/DumpDataCollector.php b/src/Symfony/Component/HttpKernel/DataCollector/DumpDataCollector.php
@@ -176,9 +176,6 @@ public function reset()
         $this->clonesIndex = 0;
     }
 
-    /**
-     * @internal
-     */
     public function serialize()
     {
         if ($this->clonesCount !== $this->clonesIndex) {
@@ -198,9 +195,6 @@ public function serialize()
         return $ser;
     }
 
-    /**
-     * @internal
-     */
     public function unserialize($data)
     {
         $this->data = unserialize($data);

Original file line number	Diff line number	Diff line change
`@@ -228,9 +228,6 @@ public function getData()`
`228`	`228`	`return $this->data;`
`229`	`229`	`}`
`230`	`230`
`231`		`- /**`
`232`		`- * @internal`
`233`		`- */`
`234`	`231`	`public function serialize()`
`235`	`232`	`{`
`236`	`233`	`if ($this->hasVarDumper) {`
Original file line number	Diff line number	Diff line change
`@@ -40,9 +40,6 @@ abstract class DataCollector implements DataCollectorInterface, \Serializable`
`40`	`40`	`*/`
`41`	`41`	`private $cloner;`
`42`	`42`
`43`		`- /**`
`44`		`- * @internal`
`45`		`- */`
`46`	`43`	`public function serialize()`
`47`	`44`	`{`
`48`	`45`	`$trace = debug_backtrace(DEBUG_BACKTRACE_PROVIDE_OBJECT, 2);`
`@@ -51,9 +48,6 @@ public function serialize()`
`51`	`48`	`return $isCalledFromOverridingMethod ? $this->data : serialize($this->data);`
`52`	`49`	`}`
`53`	`50`
`54`		`- /**`
`55`		`- * @internal`
`56`		`- */`
`57`	`51`	`public function unserialize($data)`
`58`	`52`	`{`
`59`	`53`	`$this->data = \is_array($data) ? $data : unserialize($data);`
Original file line number	Diff line number	Diff line change
`@@ -176,9 +176,6 @@ public function reset()`
`176`	`176`	`$this->clonesIndex = 0;`
`177`	`177`	`}`
`178`	`178`
`179`		`- /**`
`180`		`- * @internal`
`181`		`- */`
`182`	`179`	`public function serialize()`
`183`	`180`	`{`
`184`	`181`	`if ($this->clonesCount !== $this->clonesIndex) {`
`@@ -198,9 +195,6 @@ public function serialize()`
`198`	`195`	`return $ser;`
`199`	`196`	`}`
`200`	`197`
`201`		`- /**`
`202`		`- * @internal`
`203`		`- */`
`204`	`198`	`public function unserialize($data)`
`205`	`199`	`{`
`206`	`200`	`$this->data = unserialize($data);`