8000 [DX] rename unit test controller by frankdejonge · Pull Request #29602 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DX] rename unit test controller #29602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2018
Merged

[DX] rename unit test controller #29602

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Symfony/Component/HttpKernel/Tests/HttpKernelTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ public function testHandleWhenTheControllerIsAClosure()
public function testHandleWhenTheControllerIsAnObjectWithInvoke()
{
$dispatcher = new EventDispatcher();
$kernel = $this->getHttpKernel($dispatcher, new Controller());
$kernel = $this->getHttpKernel($dispatcher, new TestController());

$this->assertResponseEquals(new Response('foo'), $kernel->handle(new Request()));
}
Expand All @@ -216,15 +216,15 @@ public function testHandleWhenTheControllerIsAFunction()
public function testHandleWhenTheControllerIsAnArray()
{
$dispatcher = new EventDispatcher();
$kernel = $this->getHttpKernel($dispatcher, array(new Controller(), 'controller'));
$kernel = $this->getHttpKernel($dispatcher, array(new TestController(), 'controller'));

$this->assertResponseEquals(new Response('foo'), $kernel->handle(new Request()));
}

public function testHandleWhenTheControllerIsAStaticArray()
{
$dispatcher = new EventDispatcher();
$kernel = $this->getHttpKernel($dispatcher, array('Symfony\Component\HttpKernel\Tests\Controller', 'staticcontroller'));
$kernel = $this->getHttpKernel($dispatcher, array('Symfony\Component\HttpKernel\Tests\TestController', 'staticcontroller'));

$this->assertResponseEquals(new Response('foo'), $kernel->handle(new Request()));
}
Expand Down Expand Up @@ -381,7 +381,7 @@ private function assertResponseEquals(Response $expected, Response $actual)
}
}

class Controller
class TestController
{
public function __invoke()
{
Expand Down
0