[DX] rename unit test controller #29602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'t show up in the IDE autocomplete.
|
Another idea: mark it as |
|
@nicolas-grekas just tried that and it didn't have the expected result, I've just hit "invalidate caches" to verify this behaviour after a clean inspection of PHPStorm and it still shows up first. It only receives a strike through once it's used in the current file. |
|
Didn't https://youtrack.jetbrains.com/issue/WI-37750 solve the issue? Can you check if you have the latest phpstorm version? |
|
@nicolas-grekas I've updated it, it still shows it first. |
stof
approved these changes
Dec 14, 2018
ro0NL
approved these changes
Dec 14, 2018
|
Thank you @frankdejonge. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 14, 2018
This PR was merged into the 3.4 branch. Discussion ---------- [DX] rename unit test controller | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? |no | New feature? |no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Whenever I create a new controller the actually needed controller shows up second in the list of auto-completion. The first suggestion is a class defined in the test and should not ever be extended in the application. This PR renames it so that doesn't happen anymore. Example of the autocomplete issue: <img width="748" alt="screenshot 2018-12-14 at 10 33 26" src="https://user-images.githubusercontent.com/534693/49995500-a09dca80-ff8c-11e8-80b5-18890ff058b1.png"> Commits ------- d4e426c Renamed test controller from Controller to TestController so it doesn't show up in the IDE autocomplete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever I create a new controller the actually needed controller shows up second in the list of auto-completion. The first suggestion is a class defined in the test and should not ever be extended in the application. This PR renames it so that doesn't happen anymore.
Example of the autocomplete issue: