Fix env fallback to an unresolved variable #29409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d7908f9 to
6682b44
Compare
jderusse
commented
Dec 1, 2018
6682b44 to
a7456b9
Compare
a7456b9 to
ad6df01
Compare
|
Thank you @jderusse. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 17, 2018
This PR was submitted for the master branch but it was merged into the 4.2 branch instead (closes #29409). Discussion ---------- Fix env fallback to an unresolved variable | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This PR fixes a tricky case where an env processor require to resolve another parameter. For example, allowing a user to either pass a PEM key or the path to a PEM key, I could use this config ``` parameters: private_key: '%env(default:raw_key:file:PRIVATE_KEY)%' raw_key: '%env(PRIVATE_KEY)%' ``` here, the default processor, performs a `$container->getParameter('raw_key')` which fail because `raw_key` has to be resolved to. I'm not sure, if this is the right way to do it, please review it carefully. Here is my reproduct case ``` <?php require __DIR__.'/vendor/autoload.php'; use Symfony\Component\DependencyInjection\ContainerBuilder; $containerBuilder = new ContainerBuilder(); $containerBuilder->setParameter('env(PRIVATE_KEY)', 'FOO'); $containerBuilder->setParameter('raw_key', '%env(PRIVATE_KEY)%'); $containerBuilder->setParameter('private_key', '%env(default:raw_key:file:PRIVATE_KEY)%'); $containerBuilder->compile(true); var_dump($containerBuilder->getParameter('private_key')); ``` Commits ------- ad6df01 Fix env fallback to an unresolved variable
nicolas-grekas
added a commit
that referenced
this pull request
Dec 17, 2018
* 4.2: Revert "bug #29409 Fix env fallback to an unresolved variable (jderusse)"
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a tricky case where an env processor require to resolve another parameter.
For example, allowing a user to either pass a PEM key or the path to a PEM key, I could use this config
here, the default processor, performs a
$container->getParameter('raw_key')which fail becauseraw_keyhas to be resolved to.I'm not sure, if this is the right way to do it, please review it carefully.
Here is my reproduct case