8000 Fix env fallback to an unresolved variable by jderusse · Pull Request #29409 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Fix env fallback to an unresolved variable #29409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2018
Merged

Fix env fallback to an unresolved variable #29409

merged 1 commit into from
Dec 17, 2018

Conversation

jderusse
Copy link
Member
@jderusse jderusse commented Dec 1, 2018 •
edited
Loading
Q A
Branch? 4.2
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

This PR fixes a tricky case where an env processor require to resolve another parameter.

For example, allowing a user to either pass a PEM key or the path to a PEM key, I could use this config

parameters:
  private_key: '%env(default:raw_key:file:PRIVATE_KEY)%'
  raw_key: '%env(PRIVATE_KEY)%'

here, the default processor, performs a $container->getParameter('raw_key') which fail because raw_key has to be resolved to.

I'm not sure, if this is the right way to do it, please review it carefully.

Here is my reproduct case

<?php


require __DIR__.'/vendor/autoload.php';

use Symfony\Component\DependencyInjection\ContainerBuilder;

$containerBuilder = new ContainerBuilder();
$containerBuilder->setParameter('env(PRIVATE_KEY)', 'FOO');
$containerBuilder->setParameter('raw_key', '%env(PRIVATE_KEY)%');
$containerBuilder->setParameter('private_key', '%env(default:raw_key:file:PRIVATE_KEY)%');
$containerBuilder->compile(true);

var_dump($containerBuilder->getParameter('private_key'));

@jderusse jderusse mentioned this pull request Dec 1, 2018
Merged
jderusse
jderusse commented Dec 1, 2018
View reviewed changes
@nicolas-grekas nicolas-grekas added this to the 4.2 milestone Dec 1, 2018
nicolas-grekas
nicolas-grekas approved these changes Dec 13, 2018
View reviewed changes
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment