10000 FIX PHPUNIT (404 Error when download phpunit) by qlaffont-smiirl · Pull Request #29263 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

FIX PHPUNIT (404 Error when download phpunit) #29263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

FIX PHPUNIT (404 Error when download phpunit) #29263

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b232a1
PHPUNIT 5.7 -> 5.7.26 (404 Error when download phpunit)
qlaffont-smiirl Nov 19, 2018
4095805
FIX 4.8 too
qlaffont-smiirl Nov 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
PHPUNIT 5.7 -> 5.7.26 (404 Error when download phpunit) 
At this time, 5.7 ZIP return 404 error. So we can change to 5.7.26 ZIP.
  • Loading branch information
@qlaffont-smiirl
qlaffont-smiirl authored Nov 19, 2018
commit 1b232a1f9d267e5a92c86f308dff10297638c2af
2 changes: 1 addition & 1 deletion src/Symfony/Bridge/PhpUnit/bin/simple-phpunit
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ if (PHP_VERSION_ID >= 70200) {
$PHPUNIT_VERSION = getenv('SYMFONY_PHPUNIT_VERSION') ?: '6.5';
} elseif (PHP_VERSION_ID >= 50600) {
// PHPUnit 4 does not support PHP 7
$PHPUNIT_VERSION = getenv('SYMFONY_PHPUNIT_VERSION') ?: '5.7';
$PHPUNIT_VERSION = getenv('SYMFONY_PHPUNIT_VERSION') ?: '5.7.26';
Copy link
Contributor
@l-vo l-vo Nov 20, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6.5, 5.7 and 4.8 seem to be aliases for the latest patch versions. We can't fix it to a specific patch version (problem to maintain it). And maybe 4.8 and 5.7 aliases will be available again soon. What about use a fallback if the zip is not found and use github api for selecting the latest patch tag ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try saving us from any additional complexity.
Let's lobby sebastianbergmann/phpunit#3413

} else {
// PHPUnit 5.1 requires PHP 5.6+
$PHPUNIT_VERSION = '4.8';
Expand Down
0