FIX PHPUNIT (404 Error when download phpunit) #29263
Conversation
At this time, 5.7 ZIP return 404 error. So we can change to 5.7.26 ZIP.
4.8 -> 4.8.36
|
Appveyor test doesn't work because it doesn't take the modification I have to do. |
|
I confirm the issue :( |
|
See #29264 |
| @@ -20,10 +20,10 @@ if (PHP_VERSION_ID >= 70200) { | |||
| $PHPUNIT_VERSION = getenv('SYMFONY_PHPUNIT_VERSION') ?: '6.5'; | |||
| } elseif (PHP_VERSION_ID >= 50600) { | |||
| // PHPUnit 4 does not support PHP 7 | |||
| $PHPUNIT_VERSION = getenv('SYMFONY_PHPUNIT_VERSION') ?: '5.7'; | |||
| $PHPUNIT_VERSION = getenv('SYMFONY_PHPUNIT_VERSION') ?: '5.7.26'; | |||
There was a problem hiding this comment.
6.5, 5.7 and 4.8 seem to be aliases for the latest patch versions. We can't fix it to a specific patch version (problem to maintain it). And maybe 4.8 and 5.7 aliases will be available again soon. What about use a fallback if the zip is not found and use github api for selecting the latest patch tag ?
There was a problem hiding this comment.
Let's try saving us from any additional complexity.
Let's lobby sebastianbergmann/phpunit#3413
|
Reported in sebastianbergmann/phpunit#3413 |
|
I fixed this issue (but for php >=7.2) by changing the env SYMFONY_PHPUNIT_VERSION from 7.2 to 7.4 in bin/phpunit file. I guess this is what needs to be done in the bridge ... aligning the valid versions according to the php versions?! |
|
Yes me too, I have set the env var SYMFONY_PHPUNIT_VERSION and it solve the problem. But we need to change it on the file for default env. |
|
@nicolas-grekas , the author answer it. Can we merge it ? |
|
A solution might be to switch to |
|
Closing in favor of #29265 |
…-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [Bridge/PhpUnit] Use composer to download phpunit | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27753, #29263, #29264 | License | MIT | Doc PR | - Commits ------- e823f1d [Bridge/PhpUnit] Use composer to download phpunit
At this time, 5.7 & 4.8 ZIP return 404 error. So we can change to 5.7.26 & 4.8.36 ZIP.