Command::addOption should allow int in $default #29201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ea71997 to
84a41f3
Compare
The constructor for InputOption allows int on the $default parameter, but not Command::addOption $default parameter fixup: apply coding standards patch
84a41f3 to
5f8bd89
Compare
ro0NL
approved these changes
Nov 13, 2018
nicolas-grekas
approved these changes
Nov 13, 2018
|
Thank you @hultberg. |
chalasr
pushed a commit
that referenced
this pull request
Nov 14, 2018
This PR was merged into the 2.8 branch. Discussion ---------- Command::addOption should allow int in $default | Q | A | ------------- | --- | Branch? | all | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> In #28714 the documentation for `$default` on `Command::addOption` was changed to specify more specifically than `mixed`. However, there is an inconsistency as `InputOption::__construct` allows int in its `$default`, but not `Command::addOption`. This PR makes fixes that inconsistency. Commits ------- 5f8bd89 Command::addOption should allow int in $default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #28714 the documentation for
$defaultonCommand::addOptionwas changed to specify more specifically thanmixed. However, there is an inconsistency asInputOption::__constructallows int in its$default, but notCommand::addOption. This PR makes fixes that inconsistency.