minor #29201 Command::addOption should allow int in $default (hultberg)

Robin Chalas · Robin Chalas · commit c513c18fdda6 · 2018-11-14T10:59:29.000+01:00
This PR was merged into the 2.8 branch. Discussion ---------- Command::addOption should allow int in $default | Q | A | ------------- | --- | Branch? | all | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR |  In #28714 the documentation for `$default` on `Command::addOption` was changed to specify more specifically than `mixed`. However, there is an inconsistency as `InputOption::__construct` allows int in its `$default`, but not `Command::addOption`. This PR makes fixes that inconsistency. Commits ------- 5f8bd89 Command::addOption should allow int in $default
diff --git a/src/Symfony/Component/Console/Command/Command.php b/src/Symfony/Component/Console/Command/Command.php
@@ -381,11 +381,11 @@ public function addArgument($name, $mode = null, $description = '', $default = n
     /**
      * Adds an option.
      *
-     * @param string                    $name        The option name
-     * @param string|array              $shortcut    The shortcuts, can be null, a string of shortcuts delimited by | or an array of shortcuts
-     * @param int|null                  $mode        The option mode: One of the VALUE_* constants
-     * @param string                    $description A description text
-     * @param string|string[]|bool|null $default     The default value (must be null for self::VALUE_NONE)
+     * @param string                        $name        The option name
+     * @param string|array                  $shortcut    The shortcuts, can be null, a string of shortcuts delimited by | or an array of shortcuts
+     * @param int|null                      $mode        The option mode: One of the VALUE_* constants
+     * @param string                        $description A description text
+     * @param string|string[]|int|bool|null $default     The default value (must be null for self::VALUE_NONE)
      *
      * @throws InvalidArgumentException If option mode is invalid or incompatible
      *

Original file line number	Diff line number	Diff line change
`@@ -381,11 +381,11 @@ public function addArgument($name, $mode = null, $description = '', $default = n`
`381`	`381`	`/**`
`382`	`382`	`* Adds an option.`
`383`	`383`	`*`
`384`		`- * @param string $name The option name`
`385`		`- * @param string\|array $shortcut The shortcuts, can be null, a string of shortcuts delimited by \| or an array of shortcuts`
`386`		`- * @param int\|null $mode The option mode: One of the VALUE_* constants`
`387`		`- * @param string $description A description text`
`388`		`- * @param string\|string[]\|bool\|null $default The default value (must be null for self::VALUE_NONE)`
	`384`	`+ * @param string $name The option name`
	`385`	`+ * @param string\|array $shortcut The shortcuts, can be null, a string of shortcuts delimited by \| or an array of shortcuts`
	`386`	`+ * @param int\|null $mode The option mode: One of the VALUE_* constants`
	`387`	`+ * @param string $description A description text`
	`388`	`+ * @param string\|string[]\|int\|bool\|null $default The default value (must be null for self::VALUE_NONE)`
`389`	`389`	`*`
`390`	`390`	`* @throws InvalidArgumentException If option mode is invalid or incompatible`
`391`	`391`	`*`