8000 [Config] Use intersection type when referring to ParentNodeDefinitionInterface by thewilkybarkid · Pull Request #28912 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Config] Use intersection type when referring to ParentNodeDefinitionInterface #28912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2018
Merged

[Config] Use intersection type when referring to ParentNodeDefinitionInterface #28912

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Symfony/Component/Config/Definition/Builder/NodeBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ public function variableNode($name)
/**
* Returns the parent node.
*
* @return ParentNodeDefinitionInterface|NodeDefinition The parent node
* @return NodeDefinition&ParentNodeDefinitionInterface The parent node
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we have any occurrence of this syntax in the codebase.
Can you check if it's compatible with usual tooling, eg phpstorm, phpdocumentor, etc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next version of PHPStorm will support it (and falls back to the first type currently); there's a well-timed proposal for PSR-5; untested but phpDocumentor probably doesn't work.

This syntax was in https://wiki.php.net/rfc/intersection_types too.

*/
public function end()
{
Expand Down
0