[Config] Use intersection type when referring to ParentNodeDefinitionInterface #28912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -133,7 +133,7 @@ public function variableNode($name) | |||
| /** | |||
| * Returns the parent node. | |||
| * | |||
| * @return ParentNodeDefinitionInterface|NodeDefinition The parent node | |||
| * @return NodeDefinition&ParentNodeDefinitionInterface The parent node | |||
There was a problem hiding this comment.
I don't think we have any occurrence of this syntax in the codebase.
Can you check if it's compatible with usual tooling, eg phpstorm, phpdocumentor, etc?
There was a problem hiding this comment.
Next version of PHPStorm will support it (and falls back to the first type currently); there's a well-timed proposal for PSR-5; untested but phpDocumentor probably doesn't work.
This syntax was in https://wiki.php.net/rfc/intersection_types too.
nicolas-grekas
approved these changes
Nov 24, 2018
fabpot
approved these changes
Nov 26, 2018
|
Thank you @thewilkybarkid. |
ro0NL
approved these changes
Nov 26, 2018
fabpot
added a commit
that referenced
this pull request
Nov 26, 2018
…odeDefinitionInterface (thewilkybarkid) This PR was merged into the 2.8 branch. Discussion ---------- [Config] Use intersection type when referring to ParentNodeDefinitionInterface | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Allows PHPStan to understand it correctly (refs libero/content-api-bundle#2 (comment)). PHPStorm 2018.3 will add support for it too, but to help older versions I've reversed the order (so `NodeDefinition` is recognised). Commits ------- e9cdabe Use intersection type when referring to ParentNodeDefinitionInterface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows PHPStan to understand it correctly (refs libero/content-api-bundle#2 (comment)).
PHPStorm 2018.3 will add support for it too, but to help older versions I've reversed the order (so
NodeDefinitionis recognised).