-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
{{ message }}
[Form] Deprecate TimezoneType regions option #28860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
reviewed
Oct 15, 2018
yceruto
reviewed
Oct 15, 2018
|
to go after #28878 status: needs work |
|
#28878 has been merged now |
|
@yceruto a deprecated option doesnt behave correct yet, the opt-out isnt working. Each test triggers still |
|
@ro0NL Travis only shows these https://travis-ci.org/symfony/symfony/jobs/445514267#L2911 |
|
That should be fixed updating the composer constraint of the FB I guess. |
|
Ups! I just saw this https://travis-ci.org/symfony/symfony/jobs/445514267#L3728 |
|
Fixed in #28968 |
fabpot
added a commit
that referenced
this pull request
Oct 25, 2018
…(yceruto) This PR was merged into the 4.2-dev branch. Discussion ---------- [OptionsResolver] Fixed explicitly ignores a depreciation | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28860 (comment) | License | MIT | Doc PR | - When a deprecated option with default value was resolved (the first time it's called) in this case through a lazy evaluation, [the default resolution process](https://github.com/symfony/symfony/blob/8398947c9c1c1266aad0bea773d0b524e0d81643/src/Symfony/Component/OptionsResolver/OptionsResolver.php#L771-L773) takes the resolved value and here should also trigger only if the option was provided by the user or is being called from a lazy evaluation, otherwise ignore. Commits ------- 8398947 Fixed explicitly ignores a depreciation
|
Status: needs review |
xabbuh
approved these changes
Oct 25, 2018
yceruto
approved these changes
Oct 25, 2018
fabpot
approved these changes
Oct 25, 2018
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Oct 25, 2018
This PR was merged into the 4.2-dev branch. Discussion ---------- [Form] Deprecate TimezoneType regions option | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | yes | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #28848 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> I know i've added this option myself in 4.1, but given my recent development for #28624 i realized it's an opinionated feaure, which can/should be solved on user-side (`choice_filter/choice_loader` and/or `group_by`). - blocks translations as we dont have them (see #28831) - blocks possibility of switching to Intl zones which doesnt really have this filter feature (see #28836) ~While at it, i solved a few issues with `OptionsResolver` that is able to deprecate options as of 4.2 also.~ Fixed in #28878 - when resolved trigger the deprecation - allow to opt-out from triggering the deprecation - dont trigger deprecation for default values (only given ones) Commits ------- 5cb532d [Form] Deprecate TimezoneType regions option
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Oct 26, 2018
This PR was merged into the master branch. Discussion ---------- [Form] Deprecated timezone regions option see symfony/symfony#28860 Commits ------- edf7f5d [Form] Deprecated timezone regions option
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know i've added this option myself in 4.1, but given my recent development for #28624 i realized it's an opinionated feaure, which can/should be solved on user-side (
choice_filter/choice_loaderand/orgroup_by).While at it, i solved a few issues withFixed in #28878OptionsResolverthat is able to deprecate options as of 4.2 also.