E45B [OptionsResolver] Options not provided by user triggers deprecation · Issue #28848 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[OptionsResolver] Options not provided by user triggers deprecation #28848

New issue
New issue
Closed
Closed
[OptionsResolver] Options not provided by user triggers deprecation#28848
Labels
OptionsResolver
@ro0NL

Description

@ro0NL
ro0NL
opened on Oct 13, 2018

Description
Since 4.2 OptionsResolver can deprecate options, however the deprecation is triggered from offsetGet()

symfony/src/Symfony/Component/OptionsResolver/OptionsResolver.php

Line 943 in 9bec1fc

@trigger_error(strtr($deprecationMessage, array('%name%' => $option)), E_USER_DEPRECATED);

Im not sure about this, it causes the deprecation to trigger without even being provided by the user (i.e. when accessing the default value). Shouldnt it be moved to resolve() instead?

ref #27277 cc @yceruto