8000 [PhpUnitBridge] Implement startTest rather than startTestSuite by greg0ire · Pull Request #28495 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[PhpUnitBridge] Implement startTest rather than startTestSuite #28495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2018
Merged

[PhpUnitBridge] Implement startTest rather than startTestSuite #28495

merged 1 commit into from
Sep 18, 2018

Conversation

greg0ire
Copy link
Contributor
@greg0ire greg0ire commented Sep 17, 2018 •
edited
Loading

Passing a TestSuite instance to CoverageListenerTrait::testStart() will
have no effect.

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

Closes #28481

@greg0ire greg0ire changed the title Implement startTest rather than startTestSuite [PhpUnitBridge] Implement startTest rather than startTestSuite Sep 17, 2018
@greg0ire
Implement startTest rather than startTestSuite
63671d1 
Passing a TestSuite instance to CoverageListenerTrait::testStart() will
have no effect.
@greg0ire greg0ire force-pushed the implement_start_test_rather_than_start_suite branch from 0d6cfc7 to 63671d1 Compare September 17, 2018 20:28
@greg0ire greg0ire mentioned this pull request Sep 17, 2018
Closed
@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Sep 18, 2018
@nicolas-grekas
Copy link
Member

Thank you @greg0ire.

@nicolas-grekas nicolas-grekas merged commit 63671d1 into symfony:3.4 Sep 18, 2018
nicolas-grekas added a commit that referenced this pull request Sep 18, 2018
@nicolas-grekas
bug #28495 [PhpUnitBridge] Implement startTest rather than startTestS…
e597dba 
…uite (greg0ire)

This PR was merged into the 3.4 branch.

Discussion
----------

[PhpUnitBridge] Implement startTest rather than startTestSuite

Passing a TestSuite instance to CoverageListenerTrait::testStart() will
have no effect.

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Closes #28481

Commits
-------

63671d1 Implement startTest rather than startTestSuite
@greg0ire greg0ire deleted the implement_start_test_rather_than_start_suite branch September 18, 2018 11:25
This was referenced Sep 30, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Status: Needs Review
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@greg0ire @nicolas-grekas @carsonbot
0