bug #28495 [PhpUnitBridge] Implement startTest rather than startTestSuite (greg0ire)

nicolas-grekas · nicolas-grekas · commit e597dba77db0 · 2018-09-18T12:00:20.000+02:00
This PR was merged into the 3.4 branch. Discussion ---------- [PhpUnitBridge] Implement startTest rather than startTestSuite Passing a TestSuite instance to CoverageListenerTrait::testStart() will have no effect. | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes  | Fixed tickets | n/a | License | MIT | Doc PR | n/a Closes #28481 Commits ------- 63671d1 Implement startTest rather than startTestSuite
diff --git a/src/Symfony/Bridge/PhpUnit/Legacy/CoverageListenerForV5.php b/src/Symfony/Bridge/PhpUnit/Legacy/CoverageListenerForV5.php
@@ -12,8 +12,8 @@
 namespace Symfony\Bridge\PhpUnit\Legacy;
 
 /**
- * CoverageListener adds `@covers <className>` on each test suite when possible
- * to make the code coverage more accurate.
+ * CoverageListener adds `@covers <className>` on each test when possible to
+ * make the code coverage more accurate.
  *
  * @author Grégoire Pineau <lyrixx@lyrixx.info>
  *
diff --git a/src/Symfony/Bridge/PhpUnit/Legacy/CoverageListenerForV6.php b/src/Symfony/Bridge/PhpUnit/Legacy/CoverageListenerForV6.php
@@ -15,8 +15,8 @@
 use PHPUnit\Framework\Test;
 
 /**
- * CoverageListener adds `@covers <className>` on each test suite when possible
- * to make the code coverage more accurate.
+ * CoverageListener adds `@covers <className>` on each test when possible to
+ * make the code coverage more accurate.
  *
  * @author Grégoire Pineau <lyrixx@lyrixx.info>
  *
diff --git a/src/Symfony/Bridge/PhpUnit/Legacy/CoverageListenerForV7.php b/src/Symfony/Bridge/PhpUnit/Legacy/CoverageListenerForV7.php
@@ -11,13 +11,13 @@
 
 namespace Symfony\Bridge\PhpUnit\Legacy;
 
+use PHPUnit\Framework\Test;
 use PHPUnit\Framework\TestListener;
 use PHPUnit\Framework\TestListenerDefaultImplementation;
-use PHPUnit\Framework\TestSuite;
 
 /**
- * CoverageListener adds `@covers <className>` on each test suite when possible
- * to make the code coverage more accurate.
+ * CoverageListener adds `@covers <className>` on each test when possible to
+ * make the code coverage more accurate.
  *
  * @author Grégoire Pineau <lyrixx@lyrixx.info>
  *
@@ -34,8 +34,8 @@ public function __construct(callable $sutFqcnResolver = null, $warningOnSutNotFo
         $this->trait = new CoverageListenerTrait($sutFqcnResolver, $warningOnSutNotFound);
     }
 
-    public function startTestSuite(TestSuite $suite): void
+    public function startTest(Test $test): void
     {
-        $this->trait->startTest($suite);
+        $this->trait->startTest($test);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -12,8 +12,8 @@`
`12`	`12`	`namespace Symfony\Bridge\PhpUnit\Legacy;`
`13`	`13`
`14`	`14`	`/**`
`15`		- * CoverageListener adds `@covers <className>` on each test suite when possible
`16`		`- * to make the code coverage more accurate.`
	`15`	+ * CoverageListener adds `@covers <className>` on each test when possible to
	`16`	`+ * make the code coverage more accurate.`
`17`	`17`	`*`
`18`	`18`	`* @author Grégoire Pineau <lyrixx@lyrixx.info>`
`19`	`19`	`*`
Original file line number	Diff line number	Diff line change
`@@ -15,8 +15,8 @@`
`15`	`15`	`use PHPUnit\Framework\Test;`
`16`	`16`
`17`	`17`	`/**`
`18`		- * CoverageListener adds `@covers <className>` on each test suite when possible
`19`		`- * to make the code coverage more accurate.`
	`18`	+ * CoverageListener adds `@covers <className>` on each test when possible to
	`19`	`+ * make the code coverage more accurate.`
`20`	`20`	`*`
`21`	`21`	`* @author Grégoire Pineau <lyrixx@lyrixx.info>`
`22`	`22`	`*`
Original file line number	Diff line number	Diff line change
`@@ -11,13 +11,13 @@`
`11`	`11`
`12`	`12`	`namespace Symfony\Bridge\PhpUnit\Legacy;`
`13`	`13`
	`14`	`+use PHPUnit\Framework\Test;`
`14`	`15`	`use PHPUnit\Framework\TestListener;`
`15`	`16`	`use PHPUnit\Framework\TestListenerDefaultImplementation;`
`16`		`-use PHPUnit\Framework\TestSuite;`
`17`	`17`
`18`	`18`	`/**`
`19`		- * CoverageListener adds `@covers <className>` on each test suite when possible
`20`		`- * to make the code coverage more accurate.`
	`19`	+ * CoverageListener adds `@covers <className>` on each test when possible to
	`20`	`+ * make the code coverage more accurate.`
`21`	`21`	`*`
`22`	`22`	`* @author Grégoire Pineau <lyrixx@lyrixx.info>`
`23`	`23`	`*`
`@@ -34,8 +34,8 @@ public function __construct(callable $sutFqcnResolver = null, $warningOnSutNotFo`
`34`	`34`	`$this->trait = new CoverageListenerTrait($sutFqcnResolver, $warningOnSutNotFound);`
`35`	`35`	`}`
`36`	`36`
`37`		`- public function startTestSuite(TestSuite $suite): void`
	`37`	`+ public function startTest(Test $test): void`
`38`	`38`	`{`
`39`		`- $this->trait->startTest($suite);`
	`39`	`+ $this->trait->startTest($test);`
`40`	`40`	`}`
`41`	`41`	`}`