[Contracts] Add Cache contract to extend PSR-6 with tag invalidation, callback-based computation and stampede protection #28096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
b5b7e79 to
9c19606
Compare
|
Now with a |
|
Also with |
Cydonia7
reviewed
Aug 8, 2018
| use Psr\Cache\CacheItemPoolInterface; | ||
|
|
||
| /** | ||
| * An interface that extends TawAwareCacheInterface with the methods from PSR-6's CacheItemPoolInterface. |
There was a problem hiding this comment.
There's a typo: Taw => Tag, also present in the PR description.
9c19606 to
19904f9
Compare
chalasr
reviewed
Aug 8, 2018
| * | ||
| * When implemented on a PSR-6 pool, invalidation should not apply | ||
| * to deferred items. Instead, they should be committed as usual. | ||
| * This allows replacing old tagged values by news ones without |
19904f9 to
a6659db
Compare
a6659db to
0868ff4
Compare
Nyholm
approved these changes
Aug 30, 2018
There was a problem hiding this comment.
Great.
I had a discussion with @nicolas-grekas.
Approved with changes
| /** | ||
| * An interface that extends TagAwareCacheInterface with the methods from PSR-6's CacheItemPoolInterface. | ||
| */ | ||
| interface ExtendedTagAwareCacheInterface extends TagAwareCacheInterface, CacheItemPoolInterface |
| /** | ||
| * An interface that extends CacheInterface with the methods from PSR-6's CacheItemPoolInterface. | ||
| */ | ||
| interface ExtendedCacheInterface extends CacheInterface, CacheItemPoolInterface |
0868ff4 to
805b719
Compare
|
Thanks @Nyholm , PR updated. |
|
Thank you. Im 👍 |
09b706b to
f7cad20
Compare
|
(rebased) |
f7cad20 to
74506c4
Compare
|
Addressed, thanks. |
74506c4 to
fe5d5c9
Compare
… callback-based computation and stampede protection
fe5d5c9 to
ca6478b
Compare
fabpot
approved these changes
Sep 4, 2018
| interface CacheInterface | ||
| { | ||
| /** | ||
| * @param callable(ItemInterface):mixed $callback Should return the computed value for the given key/item |
There was a problem hiding this comment.
that's the declaration for the return type of the callable
nicolas-grekas
commented
Sep 4, 2018
| interface CacheInterface | ||
| { | ||
| /** | ||
| * @param callable(ItemInterface):mixed $callback Should return the computed value for the given key/item |
There was a problem hiding this comment.
that's the declaration for the return type of the callable
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Sep 4, 2018
…g invalidation, callback-based computation and stampede protection (nicolas-grekas) This PR was merged into the 4.2-dev branch. Discussion ---------- [Contracts] Add Cache contract to extend PSR-6 with tag invalidation, callback-based computation and stampede protection | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Let's separate the useful interfaces of the Cache component in Contracts. This does not include `PruneableInterface`, `MarshallerInterface` nor `*AdapterInterface` because they are too specific to the component. But `CacheInterface`, `TawAwareCacheInterface` and `ItemInterface` form a nice consistent set of features on top of PSR-6. Updating the Cache component to use these interfaces will be done in a separate PR so that we can focus on the contract itself here. Commits ------- ca6478b [Contracts] Add Cache contract to extend PSR-6 with tag invalidation, callback-based computation and stampede protection
nicolas-grekas
added a commit
that referenced
this pull request
Sep 4, 2018
This PR was merged into the 4.2-dev branch. Discussion ---------- [Cache] leverage Contracts\Cache | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Implementing #28096 Commits ------- 0a1220f [Cache] leverage Contracts\Cache
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's separate the useful interfaces of the Cache component in Contracts.
This does not include
PruneableInterface,MarshallerInterfacenor*AdapterInterfacebecause they are too specific to the component.But
CacheInterface,TawAwareCacheInterfaceandItemInterfaceform a nice consistent set of features on top of PSR-6.Updating the Cache component to use these interfaces will be done in a separate PR so that we can focus on the contract itself here.