8000 [Cache] leverage Contracts\Cache by nicolas-grekas · Pull Request #28097 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Cache] leverage Contracts\Cache #28097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2018
Merged

[Cache] leverage Contracts\Cache #28097

merged 1 commit into from
Sep 4, 2018

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Implementing #28096

@nicolas-grekas nicolas-grekas added this to the next milestone Aug 1, 2018
@nicolas-grekas nicolas-grekas force-pushed the cache-contract branch 6 times, most recently from aea99b7 to 129981a Compare August 8, 2018 07:56
Nyholm
Nyholm requested changes Aug 30, 2018
View reviewed changes
Copy link
Member
@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be updated

src/Symfony/Bundle/FrameworkBundle/Resources/config/cache.xml Outdated
@@ -149,6 +149,9 @@
<service id="Psr\Cache\CacheItemPoolInterface" alias="cache.app" />
<service id="Psr\SimpleCache\CacheInterface" alias="cache.app.simple" />
<service id="Symfony\Component\Cache\Adapter\AdapterInterface" alias="cache.app" />
<service id="Symfony\Component\Cache\CacheInterface" alias="cache.app.taggable" />
<service id="Symfony\Contracts\Cache\CacheInterface" alias="cache.app" />
<service id="Symfony\Contracts\Cache\ExtendedCacheInterface" alias="cache.app" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this line.

src/Symfony/Bundle/FrameworkBundle/Resources/config/cache.xml Outdated
<service id="Symfony\Contracts\Cache\CacheInterface" alias="cache.app" />
<service id="Symfony\Contracts\Cache\ExtendedCacheInterface" alias="cache.app" />
<service id="Symfony\Contracts\Cache\TagAwareCacheInterface" alias="cache.app.taggable" />
<service id="Symfony\Contracts\Cache\ExtendedTagAwareCacheInterface" alias="cache.app.taggable" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be TagAwareCacheInterface

@nicolas-grekas
Copy link
Member Author

thanks fixed

@nicolas-grekas nicolas-grekas force-pushed the cache-contract branch 2 times, most recently from 3e1041f to 8737949 Compare August 31, 2018 08:30
Nyholm
Nyholm approved these changes Sep 2, 2018
View reviewed changes
Copy link
Member
@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. 👍

src/Symfony/Component/Cache/CacheInterface.php
*
* @author Nicolas Grekas <p@tchwork.com>
*/
interface CacheInterface
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record: This interface has never been released, so it is okey to remove it.

@nicolas-grekas nicolas-grekas force-pushed the cache-contract branch 4 times, most recently from 2d2d0f7 to d9f19bc Compare September 4, 2018 06:46
fabpot
fabpot approved these changes Sep 4, 2018
View reviewed changes
Copy link
Member
@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With one small comment

@nicolas-grekas nicolas-grekas force-pushed the cache-contract branch 3 times, most recently from 4ad3e50 to ec22696 Compare September 4, 2018 07:00
nicolas-grekas
nicolas-grekas commented Sep 4, 2018
View reviewed changes
composer.json
"psr/simple-cache-implementation": "1.0",
"symfony/cache-contracts": "1.0",
"symfony/service-contracts": "1.0",
"symfony/translation-contracts": "1.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized we should add this. OK to you?

@nicolas-grekas
Copy link
Member Author

rebased

@nicolas-grekas nicolas-grekas merged commit 0a1220f into symfony:master Sep 4, 2018
nicolas-grekas added a commit that referenced this pull request Sep 4, 2018
@nicolas-grekas
minor #28097 [Cache] leverage Contracts\Cache (nicolas-grekas)
a0e21f8 
This PR was merged into the 4.2-dev branch.

Discussion
----------

[Cache] leverage Contracts\Cache

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Implementing #28096

Commits
-------

0a1220f [Cache] leverage Contracts\Cache
@nicolas-grekas nicolas-grekas deleted the cache-contract branch September 4, 2018 08:09
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.2 Nov 1, 2018
@nicolas-grekas nicolas-grekas mentioned this pull request Nov 18, 2018
Closed
@dereuromark dereuromark mentioned this pull request May 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
Cache Status: Reviewed
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-grekas @fabpot @Nyholm @carsonbot
0