8000 CODEOWNERS: some more rules by dunglas · Pull Request #27414 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

CODEOWNERS: some more rules #27414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2018
Merged

CODEOWNERS: some more rules #27414

merged 1 commit into from
May 30, 2018

Conversation

dunglas
Copy link
Member
@dunglas dunglas commented May 29, 2018 •
edited
Loading
Q A
Branch? 2.8
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

I missed #27079. It'll help me to deal with GitHub notifications...

@fabpot fabpot changed the base branch from 2.7 to 2.8 May 30, 2018 02:11
@fabpot fabpot changed the base branch from 2.8 to 2.7 May 30, 2018 02:11
@fabpot
Copy link
Member
fabpot commented May 30, 2018

2.7 is not maintained anymore :)

fabpot
fabpot requested changes May 30, 2018
View reviewed changes
.github/CODEOWNERS
# PropertyInfo
/src/Symfony/Component/PropertyInfo/* @dunglas
/src/Symfony/Bridge/Doctrine/PropertyInfo/* @dunglas
# Serializer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be LDAP, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faulty copy/paste ^^ (should be Serializer). Fixed.

@dunglas dunglas changed the base branch from 2.7 to 2.8 May 30, 2018 05:27
@fabpot
Copy link
Member
fabpot commented May 30, 2018

Thank you @dunglas.

@fabpot fabpot merged commit 8c62ecf into symfony:2.8 May 30, 2018
fabpot added a commit that referenced this pull request May 30, 2018
@fabpot
minor #27414 CODEOWNERS: some more rules (dunglas)
b1f6021 
This PR was merged into the 2.8 branch.

Discussion
----------

CODEOWNERS: some more rules

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

I missed #27079. It'll help me to deal with GitHub notifications...

Commits
-------

8c62ecf CODEOWNERS: some more rules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dunglas @fabpot @nicolas-grekas @stof @carsonbot
0