8000 Added .github/CODEOWNERS by lyrixx · Pull Request #27079 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Added .github/CODEOWNERS #27079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2018
Merged

Added .github/CODEOWNERS #27079

merged 1 commit into from
Apr 30, 2018

Conversation

lyrixx
Copy link
Member
@lyrixx lyrixx commented Apr 27, 2018 •
edited
Loading
Q A
Branch? 2.7
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

refs https://help.github.com/articles/about-codeowners/

@lyrixx lyrixx mentioned this pull request Apr 27, 2018
Closed
@lyrixx lyrixx changed the base branch from 3.4 to 2.7 April 27, 2018 16:04
@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Apr 27, 2018
@Tobion
Copy link
Contributor
Tobion commented Apr 28, 2018

The workflow component does not exist in the 2.7 branch. So do we really want to merge it in 2.7?

@nicolas-grekas
Copy link
Member

I suggested @lyrixx to submit on 2.7 so that we don't have to deal with any merge conflicts on this file. Sensible?

@nicolas-grekas
Copy link
Member

@csarrazi can we add you to Ldap?
@jderusse to Lock?

@jderusse
Copy link
Member

Totally 👍

@fabpot
Copy link
Member
fabpot commented Apr 30, 2018

If we were to do that, I suggest that we do it for everybody in this PR.

@lyrixx
Copy link
Member Author
lyrixx commented Apr 30, 2018

If we were to do that, I suggest that we do it for everybody in this PR.

I'm not sure everyone deal with notifications in the same way. I prefer to let people decide.

@csarrazi
Copy link
Contributor

@nicolas-grekas isn't there a requirement to be able to have write access to the repository for that feature?

In any case, sure, but as mentioned numerous times, I can not provide any sort of SLA on response time for tickets or notifications. In the medium term, if someone feels comfortable with this, I would be glad if anyone wished to take over the LDAP component.

@lyrixx
Copy link
Member Author
lyrixx commented Apr 30, 2018

PR Updated

@sroze
Copy link
Contributor
sroze commented Apr 30, 2018

I'm definitely happy to be in the Messenger one :)

@lyrixx
Copy link
Member Author
lyrixx commented Apr 30, 2018

@sroze Done ;)

sroze
sroze approved these changes Apr 30, 2018
View reviewed changes
Copy link
Contributor
@sroze sroze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@nicolas-grekas
Copy link
Member

Thank you @lyrixx.

@nicolas-grekas nicolas-grekas merged commit ffe9aaa into symfony:2.7 Apr 30, 2018
nicolas-grekas added a commit that referenced this pull request Apr 30, 2018
@nicolas-grekas
minor #27079 Added .github/CODEOWNERS (lyrixx)
c17adc6 
This PR was merged into the 2.7 branch.

Discussion
----------

Added .github/CODEOWNERS

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

---

refs https://help.github.com/articles/about-codeowners/

Commits
-------

ffe9aaa Added .github/CODEOWNERS
@lyrixx lyrixx deleted the meta-code-owner branch April 30, 2018 19:32
@dunglas dunglas mentioned this pull request May 29, 2018
Merged
fabpot added a commit that referenced this pull request May 30, 2018
@fabpot
minor #27414 CODEOWNERS: some more rules (dunglas)
b1f6021 
This PR was merged into the 2.8 branch.

Discussion
----------

CODEOWNERS: some more rules

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

I missed #27079. It'll help me to deal with GitHub notifications...

Commits
-------

8c62ecf CODEOWNERS: some more rules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@csarrazi csarrazi csarrazi approved these changes

@Tobion Tobion Tobion approved these changes

@sroze sroze sroze approved these changes

@Simperfit Simperfit Simperfit approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
9 participants
@lyrixx @Tobion @nicolas-grekas @jderusse @fabpot @csarrazi @sroze @Simperfit @carsonbot
0