[Inflector] Support pluralization in the inflector #26890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you read readme of this component?
I don't see this patch utilized in other components, so why adding unused feature into internal component? |
|
In combination with #26903 this allows us in Joomla to drop our inflector (which is in essence stable but unmaintained because we just don't have the resources to keep up with it) for something which is better maintained. |
fabpot
approved these changes
Mar 31, 2019
|
Thank you @mbabker. |
fabpot
added a commit
that referenced
this pull request
Mar 31, 2019
…abker) This PR was merged into the 4.3-dev branch. Discussion ---------- [Inflector] Support pluralization in the inflector | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | not yet | Fixed tickets | N/A | License | MIT | Doc PR | Not Yet At present the inflector only supports singularizing plural words, this PR adds the capability to pluralize singular words. Commits ------- 06920a7 Support pluralization in the inflector
|
After rebase on master, Test suite on Inflector failed : |
<
7849
a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/fabpot/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/fabpot">
fabpot
mentioned this pull request
May 9, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present the inflector only supports singularizing plural words, this PR adds the capability to pluralize singular words.