8000 [DomCrawler] Avoid a useless call to strtolower by dunglas · Pull Request #26544 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DomCrawler] Avoid a useless call to strtolower #26544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2018
Merged

[DomCrawler] Avoid a useless call to strtolower #26544

merged 1 commit into from
Mar 16, 2018

Conversation

dunglas
Copy link
Member
@dunglas dunglas commented Mar 15, 2018
Q A
Branch? 2.7
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

minor

@rpkamp
Copy link
Contributor
rpkamp commented Mar 16, 2018

That looks a lot nicer. LGTM.

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Mar 16, 2018
javiereguiluz
javiereguiluz approved these changes Mar 16, 2018
View reviewed changes
Copy link
Member
@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe PHP does this kind of optimization during the compilation phase ... but I guess it's OK to do that ourselves too.

@nicolas-grekas
Copy link
Member

Thank you @dunglas.

@nicolas-grekas nicolas-grekas merged commit c77d142 into symfony:2.7 Mar 16, 2018
nicolas-grekas added a commit that referenced this pull request Mar 16, 2018
@nicolas-grekas
minor #26544 [DomCrawler] Avoid a useless call to strtolower (dunglas)
9836dff 
This PR was merged into the 2.7 branch.

Discussion
----------

[DomCrawler] Avoid a useless call to strtolower

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | yes<!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? |no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

minor

Commits
-------

c77d142 [DomCrawler] Avoid a useless call to strtolower
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@Simperfit Simperfit Simperfit approved these changes

Assignees
No one assigned
Labels
DomCrawler Feature Status: Reviewed
4F6D
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
6 participants
@dunglas @rpkamp @nicolas-grekas @javiereguiluz @Simperfit @carsonbot
0