[DomCrawler] Avoid a useless call to strtolower

dunglas · dunglas · commit c77d1428e8fb · 2018-03-15T17:07:34.000+01:00
diff --git a/src/Symfony/Component/DomCrawler/Field/InputFormField.php b/src/Symfony/Component/DomCrawler/Field/InputFormField.php
@@ -32,11 +32,12 @@ protected function initialize()
             throw new \LogicException(sprintf('An InputFormField can only be created from an input or button tag (%s given).', $this->node->nodeName));
         }
 
-        if ('checkbox' === strtolower($this->node->getAttribute('type'))) {
+        $type = strtolower($this->node->getAttribute('type'));
+        if ('checkbox' === $type) {
             throw new \LogicException('Checkboxes should be instances of ChoiceFormField.');
         }
 
-        if ('file' === strtolower($this->node->getAttribute('type'))) {
+        if ('file' === $type) {
             throw new \LogicException('File inputs should be instances of FileFormField.');
         }
 

Original file line number	Diff line number	Diff line change
`@@ -32,11 +32,12 @@ protected function initialize()`
`32`	`32`	`throw new \LogicException(sprintf('An InputFormField can only be created from an input or button tag (%s given).', $this->node->nodeName));`
`33`	`33`	`}`
`34`	`34`
`35`		`- if ('checkbox' === strtolower($this->node->getAttribute('type'))) {`
	`35`	`+ $type = strtolower($this->node->getAttribute('type'));`
	`36`	`+ if ('checkbox' === $type) {`
`36`	`37`	`throw new \LogicException('Checkboxes should be instances of ChoiceFormField.');`
`37`	`38`	`}`
`38`	`39`
`39`		`- if ('file' === strtolower($this->node->getAttribute('type'))) {`
	`40`	`+ if ('file' === $type) {`
`40`	`41`	`throw new \LogicException('File inputs should be instances of FileFormField.');`
`41`	`42`	`}`
`42`	`43`