8000 [WebProfilerBundle] Fix Debug toolbar breaks app by xkobal · Pull Request #26368 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[WebProfilerBundle] Fix Debug toolbar breaks app #26368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[WebProfilerBundle] Fix Debug toolbar breaks app #26368

wants to merge 2 commits into from

Conversation

xkobal
Copy link
Contributor
@xkobal xkobal commented Mar 2, 2018
Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #26364
License MIT
Doc PR symfony/symfony-docs#...

Wrong method is used to count tbody.rows

@xkobal xkobal mentioned this pull request Mar 2, 2018
Closed
@xkobal xkobal changed the title Fix wrong count method Fix Debug toolbar breaks app in 2.7 branch Mar 2, 2018
@nicolas-grekas nicolas-grekas changed the title Fix Debug toolbar breaks app in 2.7 branch [WebProfilerBundle] Fix Debug toolbar breaks app Mar 2, 2018
@nicolas-grekas
Copy link
Member

Thank you @xkobal.

nicolas-grekas added a commit that referenced this pull request Mar 2, 2018
@nicolas-grekas
bug #26368 [WebProfilerBundle] Fix Debug toolbar breaks app (xkobal)
0c5f839 
This PR was squashed before being merged into the 2.7 branch (closes #26368).

Discussion
----------

[WebProfilerBundle] Fix Debug toolbar breaks app

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #26364
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Wrong method is used to count `tbody.rows`

Commits
-------

52f187e [WebProfilerBundle] Fix Debug toolbar breaks app
This was referenced Mar 5, 2018
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xkobal @nicolas-grekas @carsonbot
0