8000 Fix Debug toolbar breaks app by xkobal · Pull Request #26366 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Fix Debug toolbar breaks app #26366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix Debug toolbar breaks app #26366

wants to merge 1 commit into from

Conversation

xkobal
Copy link
Contributor
@xkobal xkobal commented Mar 2, 2018 •
edited
Loading
Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #26364
License MIT
Doc PR symfony/symfony-docs#...

Wrong method is used to count tbody.rows

@xkobal
Copy link
Contributor Author
xkobal commented Mar 2, 2018 •
edited
Loading

One error that has nothing to do with my PR :-(

@nicolas-grekas
Copy link
Member

The same buggy code exists also on 2.7, can you send a PR please?

@xkobal
Copy link
Contributor Author
xkobal commented Mar 2, 2018

I will

@xkobal
Copy link
Contributor Author
xkobal commented Mar 2, 2018

#26368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xkobal @nicolas-grekas @carsonbot
0