8000 [Form][WCAG] Errors sign for people that do not see colors by Nyholm · Pull Request #26327 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Form][WCAG] Errors sign for people that do not see colors #26327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

[Form][WCAG] Errors sign for people that do not see colors #26327

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d9ad1cc
Adding error sign
Nyholm Feb 26, 2018
839c2b4
Fixed tests
Nyholm Feb 26, 2018
4632f79
Adding "error" badge
Nyholm Feb 28, 2018
e938404
Updated conflicts on composer.json
Nyholm Mar 1, 2018
3445665
Adding translations
Nyholm Mar 1, 2018
ac33927
Added some more translations
Nyholm Mar 1, 2018
ee3045c
Added more languages
Nyholm Mar 1, 2018
b61ed78
Fixed tests
Nyholm Mar 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Symfony/Bridge/Twig/Resources/views/Form/bootstrap_4_layout.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@
<div class="{% if form is not rootform %}invalid-feedback d-block{% else %}alert alert-danger{% endif %}">
<ul class="list-unstyled mb-0">
{%- for error in errors -%}
<li>{{ error.message }}</li>
<li><span class="initialism form-error-icon badge badge-danger">{{ 'error'|trans }}</span> <span class="form-error-message">{{ error.message }}</span></li>
Copy link
Member
@nicolas-grekas nicolas-grekas 8000 Mar 1, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a raw idea: instead of "error", we put that "X" unicode cross,
then we add a translation table where this "X" maps to "ERROR" in english, same in a few other languages,
but if we don't have the translation for the word "error", the cross is displayed instead - as it is more universal than "error", isn't it?
makes sense?

{%- endfor -%}
</ul>
</div>
Expand Down
5 changes: 4 additions & 1 deletion src/Symfony/Component/Form/Tests/AbstractBootstrap4HorizontalLayoutTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,10 @@ public function testRow()
[
./div[
./ul
[./li[.="[trans]Error![/trans]"]]
[./li
[./span[.="[trans]error[/trans]"]]
[./span[.="[trans]Error![/trans]"]]
]
[count(./li)=1]
]
]
Expand Down
12 changes: 9 additions & 3 deletions src/Symfony/Component/Form/Tests/AbstractBootstrap4LayoutTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,10 @@ public function testRow()
[
./div[
./ul
[./li[.="[trans]Error![/trans]"]]
[./li
[./span[.="[trans]error[/trans]"]]
[./span[.="[trans]Error![/trans]"]]
]
[count(./li)=1]
]
]
Expand Down Expand Up @@ -166,9 +169,12 @@ public function testErrors()
[@class="list-unstyled mb-0"]
[
./li
[.="[trans]Error 1[/trans]"]
[./span[.="[trans]error[/trans]"]]
[./span[.="[trans]Error 1[/trans]"]]

/following-sibling::li
[.="[trans]Error 2[/trans]"]
[./span[.="[trans]error[/trans]"]]
[./span[.="[trans]Error 2[/trans]"]]
]
[count(./li)=2]
]
Expand Down
0