10000 [Form][WCAG] Errors sign for people that do not see colors by Nyholm · Pull Request #26327 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Form][WCAG] Errors sign for people that do not see colors #26327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

[Form][WCAG] Errors sign for people that do not see colors #26327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d9ad1cc
Adding error sign
Nyholm Feb 26, 2018
839c2b4
Fixed tests
Nyholm Feb 26, 2018
4632f79
Adding "error" badge
Nyholm Feb 28, 2018
e938404
Updated conflicts on composer.json
Nyholm Mar 1, 2018
3445665
Adding translations
Nyholm Mar 1, 2018
ac33927
Added some more translations
Nyholm Mar 1, 2018
ee3045c
Added more languages
Nyholm Mar 1, 2018
b61ed78
Fixed tests
Nyholm Mar 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Symfony/Bridge/Twig/Resources/views/Form/bootstrap_4_layout.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@
<div class="{% if form is not rootform %}invalid-feedback d-block{% else %}alert alert-danger{% endif %}">
<ul class="list-unstyled mb-0">
{%- for error in errors -%}
<li>{{ error.message }}</li>
<li><span class="initialism form-error-icon badge badge-danger">{{ 'Error'|trans({}, 'validators') }}</span> <span class="form-error-message">{{ error.message }}</span></li>
{%- endfor -%}
</ul>
</div>
Expand Down
5 changes: 4 additions & 1 deletion src/Symfony/Component/Form/Tests/AbstractBootstrap4HorizontalLayoutTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,10 @@ public function testRow()
[
./div[
./ul
[./li[.="[trans]Error![/trans]"]]
[./li
[./span[.="[trans]Error[/trans]"]]
[./span[.="[trans]Error![/trans]"]]
]
[count(./li)=1]
]
]
Expand Down
12 changes: 9 additions & 3 deletions src/Symfony/Component/Form/Tests/AbstractBootstrap4LayoutTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,10 @@ public function testRow()
[
./div[
./ul
[./li[.="[trans]Error![/trans]"]]
[./li
[./span[.="[trans]Error[/trans]"]]
[./span[.="[trans]Error![/trans]"]]
]
[count(./li)=1]
]
]
Expand Down Expand Up @@ -166,9 +169,12 @@ public function testErrors()
[@class="list-unstyled mb-0"]
[
./li
[.="[trans]Error 1[/trans]"]
[./span[.="[trans]Error[/trans]"]]
[./span[.="[trans]Error 1[/trans]"]]

/following-sibling::li
[.="[trans]Error 2[/trans]"]
[./span[.="[trans]Error[/trans]"]]
[./span[.="[trans]Error 2[/trans]"]]
]
[count(./li)=2]
]
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Form/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"symfony/doctrine-bridge": "<2.7",
"symfony/framework-bundle": "<3.4",
"symfony/http-kernel": "<3.3.5",
"symfony/twig-bridge": "<3.4"
"symfony/twig-bridge": "<3.4.5|<4.0.5,>=4.0"
},
"suggest": {
"symfony/validator": "For form validation.",
Expand Down
4 changes: 4 additions & 0 deletions src/Symfony/Component/Validator/Resources/translations/validators.bg.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,10 @@
<source>This is not a valid Business Identifier Code (BIC).</source>
<target>Невалиден бизнес идентификационен код (BIC).</target>
</trans-unit>
<trans-unit id="82">
<source>Error</source>
<target>Грешка</target>
</trans-unit>
</body>
</file>
</xliff>
4 changes: 4 additions & 0 deletions src/Symfony/Component/Validator/Resources/translations/validators.cs.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,10 @@
<source>This is not a valid Business Identifier Code (BIC).</source>
<target>Tato hodnota není platný identifikační kód podniku (BIC).</target>
</trans-unit>
<trans-unit id="82">
<source>Error</source>
<target>Chyba</target>
</trans-unit>
</body>
</file>
</xliff>
4 changes: 4 additions & 0 deletions src/Symfony/Component/Validator/Resources/translations/validators.da.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,10 @@
<source>This value is not a valid ISSN.</source>
<target>Værdien er ikke en gyldig ISSN.</target>
</trans-unit>
<trans-unit id="82">
<source>Error</source>
<target>Fejl</target>
</trans-unit>
</body>
</file>
</xliff>
4 changes: 4 additions & 0 deletions src/Symfony/Component/Validator/Resources/translations/validators.de.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,10 @@
<source>This is not a valid Business Identifier Code (BIC).</source>
<target>Dieser Wert ist kein gültiger BIC.</target>
</trans-unit>
<trans-unit id="82">
<source>Error</source>
<target>Fehler</target>
</trans-unit>
</body>
</file>
</xliff>
4 changes: 4 additions & 0 deletions src/Symfony/Component/Validator/Resources/translations/validators.en.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,10 @@
<source>This is not a valid Business Identifier Code (BIC).</source>
<target>This is not a valid Business Identifier Code (BIC).</target>
</trans-unit>
<trans-unit id="82">
<source>Error</source>
<target>Error</target>
</trans-unit>
</body>
</file>
</xliff>
10000
4 changes: 4 additions & 0 deletions src/Symfony/Component/Validator/Resources/translations/validators.es.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,10 @@
<source>This is not a valid Business Identifier Code (BIC).</source>
<target>No es un Código de Identificación Bancaria (BIC) válido.</target>
</trans-unit>
<trans-unit id="82">
<source>Error</source>
<target>Error</target>
</trans-unit>
</body>
</file>
</xliff>
4 changes: 4 additions & 0 deletions src/Symfony/Component/Validator/Resources/translations/validators.eu.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,10 @@
<source>This value should not be identical to {{ compared_value_type }} {{ compared_value }}.</source>
<target>Balio hau ez litzateke {{ compared_value_type }} {{ compared_value }}-(r)en berbera izan behar.</target>
</trans-unit>
<trans-unit id="82">
<source>Error</source>
<target>Errore</target>
</trans-unit>
</body>
</file>
</xliff>
4 changes: 4 additions & 0 deletions src/Symfony/Component/Validator/Resources/translations/validators.fi.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,10 @@
<source>Unsupported card type or invalid card number.</source>
<target>Tätä korttityyppiä ei tueta tai korttinumero on virheellinen.</target>
</trans-unit>
<trans-unit id="82">
<source>Error</source>
<target>Virhe</target>
</trans-unit>
</body>
</file>
</xliff>
4 changes: 4 additions & 0 deletions src/Symfony/Component/Validator/Resources/translations/validators.fr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,10 @@
<source>This is not a valid Business Identifier Code (BIC).</source>
<target>Ce n'est pas un code universel d'identification des banques (BIC) valide.</target>
</trans-unit>
<trans-unit id="82">
<source>Error</source>
<target>Erreur</target>
</trans-unit>
</body>
</file>
</xliff>
4 changes: 4 additions & 0 deletions src/Symfony/Component/Validator/Resources/translations/validators.hr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,10 @@
<source>This is not a valid Business Identifier Code (BIC).</source>
<target>Ovo nije validan poslovni identifikacijski broj (BIC).</target>
</trans-unit>
<trans-unit id="82">
<source>Error</source>
<target>Greška</target>
</trans-unit>
</body>
</file>
</xliff>
4 changes: 4 additions & 0 deletions src/Symfony/Component/Validator/Resources/translations/validators.hu.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,10 @@
<source>This is not a valid Business Identifier Code (BIC).</source>
<target>Érvénytelen nemzetközi bankazonosító kód (BIC/SWIFT).</target>
</trans-unit>
<trans-unit id="82">
<source>Error</source>
<target>Hiba</target>
</trans-unit>
</body>
</file>
</xliff>
4 changes: 4 additions & 0 deletions src/Symfony/Component/Validator/Resources/translations/validators.it.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,10 @@
<source>This is not a valid Business Identifier Code (BIC).</source>
<target>Questo valore non è un codice BIC valido.</target>
</trans-unit>
<trans-unit id="82">
<source>Error</source>
<target>Errore</target>
</trans-unit>
</body>
</file>
</xliff>
4 changes: 4 additions & 0 deletions src/Symfony/Component/Validator/Resources/translations/validators.lt.xlf
93C6
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,10 @@
<source>An empty file is not allowed.</source>
<target>Failas negali būti tuščias.</target>
</trans-unit>
<trans-unit id="82">
<source>Error</source>
<target>Klaida</target>
</trans-unit>
</body>
</file>
</xliff>
4 changes: 4 additions & 0 deletions src/Symfony/Component/Validator/Resources/translations/validators.nl.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,10 @@
<source>This is not a valid Business Identifier Code (BIC).</source>
<target>Dit is geen geldige bedrijfsidentificatiecode (BIC/SWIFT).</target>
</trans-unit>
<trans-unit id="82">
<source>Error</source>
<target>Fout</target>
</trans-unit>
</body>
</file>
</xliff>
4 changes: 4 additions & 0 deletions src/Symfony/Component/Validator/Resources/translations/validators.pl.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,10 @@
<source>This is not a valid Business Identifier Code (BIC).</source>
<target>Ta wartość nie jest poprawnym kodem BIC (Business Identifier Code).</target>
</trans-unit>
<trans-unit id="82">
<source>Error</source>
<target>Błąd</target>
</trans-unit>
</body>
</file>
</xliff>
4 changes: 4 additions & 0 deletions src/Symfony/Component/Validator/Resources/translations/validators.pt.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,10 @@
<source>An empty file is not allowed.</source>
<target>Ficheiro vazio não é permitido.</target>
</trans-unit>
<trans-unit id="82">
<source>Error</source>
<target>Erro</target>
</trans-unit>
</body>
</file>
</xliff>
4 changes: 4 additions & 0 deletions src/Symfony/Component/Validator/Resources/translations/validators.ro.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,10 @@
<source>This value should not be identical to {{ compared_value_type }} {{ compared_value }}.</source>
<target>Această valoare nu trebuie să fie identică cu {{ compared_value_type }} {{ compared_value }}.</target>
</trans-unit>
<trans-unit id="82">
<source>Error</source>
<target>Eroare</target>
</trans-unit>
</body>
</file>
</xliff>
4 changes: 4 additions & 0 deletions src/Symfony/Component/Validator/Resources/translations/validators.ru.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,10 @@
<source>This value does not match the expected {{ charset }} charset.</source>
<target>Значение не совпадает с ожидаемой {{ charset }} кодировкой.</target>
</trans-unit>
<trans-unit id="82">
<source>Error</source>
<target>Ошибка</target>
</trans-unit>
</body>
</file>
</xliff>
4 changes: 4 additions & 0 deletions src/Symfony/Component/Validator/Resources/translations/validators.sv.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,10 @@
<source>This is not a valid Business Identifier Code (BIC).</source>
<target>Detta är inte en giltig BIC-kod.</target>
</trans-unit>
<trans-unit id="82">
<source>Error</source>
<target>Fel</target>
</trans-unit>
</body>
</file>
</xliff>
4 changes: 4 additions & 0 deletions src/Symfony/Component/Validator/Resources/translations/validators.tr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,10 @@
<source>Unsupported card type or invalid card number.</source>
<target>Desteklenmeyen kart tipi veya geçersiz kart numarası.</target>
</trans-unit>
<trans-unit id="82">
<source>Error</source>
<target>Hata</target>
</trans-unit>
</body>
</file>
</xliff>
4 changes: 4 additions & 0 deletions src/Symfony/Component/Validator/Resources/translations/validators.uk.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,10 @@
<source>This value should not be identical to {{ compared_value_type }} {{ compared_value }}.</source>
<target>Значення не повинно бути ідентичним {{ compared_value_type }} {{ compared_value }}.</target>
</trans-unit>
<trans-unit id="82">
<source>Error</source>
<target>Помилка</target>
</trans-unit>
</body>
</file>
</xliff>
4 changes: 4 additions & 0 deletions src/Symfony/Component/Validator/Resources/translations/validators.zh_CN.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,10 @@
<source>This value does not match the expected {{ charset }} charset.</source>
<target>该值不符合 {{ charset }} 编码。</target>
</trans-unit>
<trans-unit id="82">
<source>Error</source>
<target>错误</target>
</trans-unit>
</body>
</file>
</xliff>
0