8000 [Serializer] Pass the serializer context to PropertyTypeExtractorInterface by dunglas · Pull Request #26235 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Serializer] Pass the serializer context to PropertyTypeExtractorInterface #26235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Serializer] Pass the serializer context to PropertyTypeExtractorInterface #26235

wants to merge 1 commit into from

Conversation

dunglas
Copy link
Member
@dunglas dunglas commented Feb 19, 2018 •
edited
Loading

…rface

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #25807
License MIT
Doc PR n/a

@dunglas dunglas removed the BC Break label Feb 19, 2018
@nicolas-grekas nicolas-grekas changed the title [Serializer] Pass the serializer context to PropertyTypeExtractorInte… [Serializer] Pass the serializer context to PropertyTypeExtractorInterface Feb 19, 2018
@nicolas-grekas nicolas-grekas added this to the 4.1 milestone Feb 19, 2018
@nicolas-grekas
Copy link
Member

didn't we merge something similar as bug fix recently?

@nicolas-grekas
Copy link
Member

In #26043 actually

@dunglas
Copy link
8000 Member Author
dunglas commented Feb 19, 2018 •
edited
Loading

It's not the same. In this one the idea is to give access to the serialization context in the PropertyInfo component.

@nicolas-grekas
Copy link
Member

Ok :) what about adding a test case?

@dunglas
Copy link
Member Author
dunglas commented Feb 19, 2018

bof 😋 (i'll add it)

@GuilhemN
Copy link
Contributor

If we don't have an actual use case, i'd rather not do this since it makes caching much harder (values of circular reference fields are dynamic, aren't they?). I think it was already rejected in the past because of this.

@dunglas
Copy link
Member Author
dunglas commented Feb 21, 2018

Indeed it's bad in term of cache.

@nicolas-grekas nicolas-grekas modified the milestones: 4.1, next Apr 20, 2018
@dunglas dunglas closed this Jun 30, 2018
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.2 Nov 1, 2018
@xabbuh xabbuh mentioned this pull request Apr 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature Serializer Status: Needs Review
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@dunglas @nicolas-grekas @GuilhemN @carsonbot
0