8000 [Serialized] add context to serialize and deserialize by andrey1s · Pull Request #26043 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Serialized] add context to serialize and deserialize #26043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2018
Merged

[Serialized] add context to serialize and deserialize #26043

merged 1 commit into from
Feb 11, 2018

Conversation

andrey1s
Copy link
@andrey1s andrey1s commented Feb 4, 2018
Q A
Branch? 3.3
Bug fix? yes
Tests pass? yes
License MIT

added context to supportsDecoding needsNormalization and supportsEncoding

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Feb 5, 2018
@Nek-
Copy link
Contributor
Nek- commented Feb 7, 2018

Tests failure is not related. @andrey1s to complete your PR you can also update the CHANGELOG.md file.

@nicolas-grekas nicolas-grekas changed the title add context to serialize and deserialize [Serialized] add context to serialize and deserialize Feb 11, 2018
@nicolas-grekas nicolas-grekas changed the base branch from 3.3 to 3.4 February 11, 2018 11:23
@nicolas-grekas
Copy link
Member

Thank you @andrey1s.

@nicolas-grekas nicolas-grekas merged commit 6f8d5e2 into symfony:3.4 Feb 11, 2018
nicolas-grekas added a commit that referenced this pull request Feb 11, 2018
@nicolas-grekas
bug #26043 [Serialized] add context to serialize and deserialize (and…
94675e1 
…rey1s)

This PR was merged into the 3.4 branch.

Discussion
----------

[Serialized] add context to serialize and deserialize

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| Tests pass?   | yes
| License       | MIT

added context to `supportsDecoding` `needsNormalization` and `supportsEncoding`

Commits
-------

6f8d5e2 add context to serialize and deserialize
@andrey1s andrey1s deleted the serializer/context branch February 11, 2018 11:37
@nicolas-grekas nicolas-grekas mentioned this pull request Feb 19, 2018
Closed
This was referenced Mar 1, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@Nek- Nek- Nek- approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
5 participants
@andrey1s @Nek- @nicolas-grekas @dunglas @carsonbot
0