8000 [HttpFoundation] Fix missing "throw" in JsonResponse by nicolas-grekas · Pull Request #26228 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpFoundation] Fix missing "throw" in JsonResponse #26228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2018
Merged

[HttpFoundation] Fix missing "throw" in JsonResponse #26228

merged 1 commit into from
Feb 19, 2018

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Feb 19, 2018
dunglas
dunglas approved these changes Feb 19, 2018
View reviewed changes
Copy link
Member
@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it deserves a test :)

@nicolas-grekas
Copy link
Member Author

bof for a test :)

nicolas-grekas added a commit that referenced this pull request Feb 19, 2018
@nicolas-grekas
bug #26228 [HttpFoundation] Fix missing "throw" in JsonResponse (nico…
820ad07 
…las-grekas)

This PR was merged into the 2.7 branch.

Discussion
----------

[HttpFoundation] Fix missing "throw" in JsonResponse

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

7490f0b [HttpFoundation] Fix missing "throw" in JsonResponse
@nicolas-grekas nicolas-grekas deleted the json-fix branch February 26, 2018 18:23
This was referenced Feb 28, 2018
Closed
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas approved these changes

@Simperfit Simperfit Simperfit approved these changes

Assignees
No one assigned
Labels
Bug HttpFoundation Status: Reviewed
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-grekas @dunglas @Simperfit @carsonbot
0