bug #26228 [HttpFoundation] Fix missing "throw" in JsonResponse (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 820ad0732fd6 · 2018-02-19T17:19:49.000+01:00
This PR was merged into the 2.7 branch. Discussion ---------- [HttpFoundation] Fix missing "throw" in JsonResponse | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 7490f0b [HttpFoundation] Fix missing "throw" in JsonResponse
diff --git a/src/Symfony/Component/HttpFoundation/JsonResponse.php b/src/Symfony/Component/HttpFoundation/JsonResponse.php
@@ -148,6 +148,7 @@ public function setData($data = array())
                 if (\PHP_VERSION_ID < 50500 || !interface_exists('JsonSerializable', false)) {
                     restore_error_handler();
                 }
+                throw $e;
             } catch (\Exception $e) {
                 if (\PHP_VERSION_ID < 50500 || !interface_exists('JsonSerializable', false)) {
                     restore_error_handler();

Original file line number	Diff line number	Diff line change
`@@ -148,6 +148,7 @@ public function setData($data = array())`
`148`	`148`	`if (\PHP_VERSION_ID < 50500 \|\| !interface_exists('JsonSerializable', false)) {`
`149`	`149`	`restore_error_handler();`
`150`	`150`	`}`
	`151`	`+ throw $e;`
`151`	`152`	`} catch (\Exception $e) {`
`152`	`153`	`if (\PHP_VERSION_ID < 50500 \|\| !interface_exists('JsonSerializable', false)) {`
`153`	`154`	`restore_error_handler();`