8000 Update excluded_ajax_paths for sf4 by jenaye · Pull Request #26177 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Update excluded_ajax_paths for sf4 #26177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Update excluded_ajax_paths for sf4 #26177

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ccf4eaf
update excluded_ajax_paths for sf4
jenaye Feb 14, 2018
423abe9
update after @ro0NL and @stof review
jenaye Feb 21, 2018
c27b969
update unit test
jenaye Feb 21, 2018
869b81d
delete '?:' who are used only to increase perf with big regex
jenaye Feb 21, 2018
92ab3cc
escape dot
jenaye Feb 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
8000
Loading
Diff view
Diff view
Next Next commit
update excluded_ajax_paths for sf4
  • Loading branch information
@jenaye
jenaye committed Feb 14, 2018
commit ccf4eafc396f43f20289cee11c2c75e603cbc0d7
2 changes: 1 addition & 1 deletion src/Symfony/Bundle/WebProfilerBundle/DependencyInjection/Configuration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public function getConfigTreeBuilder()
->children()
->booleanNode('toolbar')->defaultFalse()->end()
->booleanNode('intercept_redirects')->defaultFalse()->end()
->scalarNode('excluded_ajax_paths')->defaultValue('^/(app(_[\\w]+)?\\.php/)?_wdt')->end()
->scalarNode('excluded_ajax_paths')->defaultValue('index.php?_wdt')->end()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's not the right update. It will now match index.php_wdt and index.ph_wdt (and anywhere in the URL, not only at the start), while it should be matching /_wdt and /index.php/_wdt

->end()
;

Expand Down
0